typescript-fetch: default to es6 support
Merged
WI
4mo ago+38+38+01234567890123456789-43-43-01234567890123456789
default to ES6 support as ES5 support has been deprecated in TypeScript
FYI @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10) @dennisameling (2026/02)
PR checklist
- Read the contribution guidelines.
- Run the following to build the project and update samples:
(For Windows users, please run the script in WSL)./mvnw clean package || exit ./bin/generate-samples.sh ./bin/configs/*.yaml || exit ./bin/utils/export_docs_generators.sh || exit
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*.
IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed. - If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Summary by cubic
Defaulted the typescript-fetch generator to ES2015+ and now produce dual builds (CommonJS + ESM) by default. This adds ESM output and package fields, and removes ES5-specific config.
-
New Features
- Always generate
tsconfig.esm.jsonand build ESM todist/esmviatsc && tsc -p tsconfig.esm.json. package.json: add"module": "./dist/esm/index.js"and"sideEffects": false.- Remove legacy ES5
libsettings fromtsconfig. - Update samples to reflect the new defaults.
- Update tests to drop the ES5 path and expect ESM config by default.
- Always generate
-
Migration
- No changes needed for CommonJS consumers (
mainstays the same). - If you relied on ES5 targets, move to ES2015+ or add polyfills.
- Remove any tooling that assumes a
supportsES6-conditional output.
- No changes needed for CommonJS consumers (