Skip to content

Fix #10631 Fix PojoUtils support localdatetime,lcaldate,localtime serializable and deserialize - #10632

Merged
AlbumenJ merged 1 commit into
apache:masterfrom
wuwen5:LocalDateTime
Sep 22, 2022
Merged

AlbumenJ merged 1 commit into
apache:masterfrom
wuwen5:LocalDateTime

Conversation

@wuwen5

@wuwen5 wuwen5 commented Sep 16, 2022

Copy link
Copy Markdown
Contributor

What is the purpose of the change

fixed #10631

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter

codecov-commenter commented Sep 16, 2022 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.88%. Comparing base (bcf9764) to head (9923b2c).

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #10632   +/-   ##
=========================================
  Coverage     60.88%   60.88%           
+ Complexity      449      447    -2     
=========================================
  Files          1101     1101           
  Lines         44538    44542    +4     
  Branches       6490     6492    +2     
=========================================
+ Hits          27118    27121    +3     
- Misses        14448    14453    +5     
+ Partials       2972     2968    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlbumenJ
AlbumenJ changed the base branch from master to 3.1 September 19, 2022 06:24
@AlbumenJ
AlbumenJ changed the base branch from 3.1 to master September 19, 2022 06:24
@AlbumenJ

Copy link
Copy Markdown
Member

Please fix to 3.1 branch.

@wuwen5

wuwen5 commented Sep 19, 2022

Copy link
Copy Markdown
Contributor Author

Currently, this is based on the 2.7 branch modification, and I re initiated the PR #10638

@AlbumenJ AlbumenJ closed this Sep 19, 2022
@wuwen5

wuwen5 commented Sep 20, 2022

Copy link
Copy Markdown
Contributor Author

@AlbumenJ Version 2.7.x is still used in our production environment. Can we solve this issue in 2.7.x?

@AlbumenJ AlbumenJ reopened this Sep 21, 2022
@AlbumenJ

Copy link
Copy Markdown
Member

@AlbumenJ Version 2.7.x is still used in our production environment. Can we solve this issue in 2.7.x?

OK, I will merge it into 2.7.x. BTW, 2.7.x will not merge in any feature in the future and will be in EOF in the next several months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants