Repository navigation
[master] fix #9847 - #9848
Merged
Merged
[master] fix #9847#9848
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9848 +/- ##
============================================
+ Coverage 60.87% 60.89% +0.02%
+ Complexity 448 447 -1
============================================
Files 1100 1100
Lines 44560 44557 -3
Branches 6487 6486 -1
============================================
+ Hits 27125 27135 +10
+ Misses 14464 14456 -8
+ Partials 2971 2966 -5
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #9847
翻了以前的一些issue 比如 #8212 和 #5122 都提到过这个问题,我认为这段强校验的代码没必要存在。
虽然可以通过SPI来扩展,但是还是给用户带来了一定的困扰。