Repository navigation
Fixed incorrect cast getting float from array - #604
Merged
Merged
Conversation
Added test for getting float from array
johnjaylward
approved these changes
Apr 28, 2021
Contributor
Author
|
@johnjaylward thanks for approving these changes, it appears that there is a workflow awaiting approval as well since I am a first-time contributor, not sure if you can unstick that as well? Thanks! |
Owner
|
What problem does this code solve? Risks Changes to the API? Will this require a new release? Should the documentation be updated? Does it break the unit tests? Was any code refactored in this commit? Review status |
Owner
|
Starting 3-day comment window. |
Contributor
|
There is a new test @stleary |
Owner
|
Thanks @johnjaylward I saw the test but just didn't read it closely. Review updated. #readthecode |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I noticed that if a double is added to a JSONArray and then retrieved with getFloat(), a class cast exception was raised. This case is handled correctly by JSONObject (as opposed to array).
The root cause turned out to be an incorrect cast. I corrected the cast and also added a test for this case. I tried to closely follow the existing coding conventions as well as the corresponding code in JSONObject.
Please let me know if you need any more information. Thanks for maintaining this project!
Sincerely,
Ian Lovejoy