Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: AzureAD/microsoft-identity-web
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4.12.2
Choose a base ref
...
head repository: AzureAD/microsoft-identity-web
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4.13.0
Choose a head ref
  • 10 commits
  • 15 files changed
  • 8 contributors

Commits on Jul 6, 2026

  1. Categorize managed-identity E2E tests and exclude them from the PR bu…

    …ild (#3923)
    
    * Categorize managed-identity E2E tests and exclude them from the PR build
    
    The `AcquireTokenManagedIdentity` E2E test acquires a token for a user-assigned
    managed identity via IMDS, so it requires an MI assigned to the build host. It
    passes on the official OneBranch pipeline (VM-based agents that have the MI) but
    fails on Microsoft-hosted agents (no MI, IMDS returns "Identity not found").
    
    Following the MSAL approach of categorizing MI tests and running them only where
    an MI is available:
    
    - Add a shared `TestCategories.ManagedIdentity` ("MI_E2E") constant and tag the
      `AcquireTokenManagedIdentity` class with `[Trait("Category", "MI_E2E")]`.
    - Parameterize `template-run-unit-tests.yaml` with `e2eTestFilterCriteria`
      (default empty, so the release build and any other consumer are unaffected).
    - The PR build (azure-pipelines.yml) passes `Category!=MI_E2E` to exclude the MI
      tests, which run on Microsoft-hosted agents.
    
    The official OneBranch pipeline uses its own inline VSTest steps and is not
    affected, so it continues to run the MI tests on VM-based agents.
    
    Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    
    * Trigger ADO PR pipeline
    
    Empty commit to kick off the newly added ADO PR pipeline trigger.
    
    Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    iarekk and Copilot authored Jul 6, 2026
    Configuration menu
    Copy the full SHA
    d963e30 View commit details
    Browse the repository at this point in the history
  2. Add more tests for TokenAcquisitionMetadata.ExpiresOn from Authentica…

    …tionResult (#3904)
    
    * Populate TokenAcquisitionMetadata.ExpiresOn from AuthenticationResult
    
    Maps AuthenticationResult.ExpiresOn into the token-acquisition metadata
    surface so callers get the access token's absolute expiry on success.
    Adds unit coverage (present/absent metadata) and an end-to-end assertion
    on the DefaultAuthorizationHeaderProvider metadata flow.
    
    Requires Microsoft.Identity.Abstractions 12.4.0 (adds ExpiresOn).
    
    Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    
    * Add FromMsal test asserting ExpiresOn on top-level result and metadata
    
    Covers the top-level AcquireTokenResult.ExpiresOn mapping, complementing
    the existing GetMetadata (metadata surface) and provider e2e coverage.
    
    Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    
    * Remove duplicate ExpiresOn mapping (master already has it)
    
    master gained the ExpiresOn mapping independently; the merge left two identical
    assignments in MapMetadata, causing CS1912. Drop the duplicate so the factory
    matches master and this PR carries just the tests.
    
    Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    neha-bhargava and Copilot authored Jul 6, 2026
    Configuration menu
    Copy the full SHA
    7c7626e View commit details
    Browse the repository at this point in the history
  3. Test: use shared Msal_Integration_tests UAMI in MI token acquirer E2E…

    … test (#3926)
    
    Switch AcquireTokenWithManagedIdentity_UserAssignedAsync from the
    Id4STesting managed identity (clientId 5bcd1685-...) to the consolidated
    lab UAMI Msal_Integration_tests (clientId 45344e7d-...) in resource group
    MSAL_MSI. This lets us retire the single-purpose Id4STesting identity and
    reuse the shared lab identity already used by MSAL.NET E2E tests.
    
    The test only acquires a token for the https://vault.azure.net audience,
    so no Key Vault permissions are required; the new identity is a superset.
    
    Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    RyAuld and Copilot authored Jul 6, 2026
    Configuration menu
    Copy the full SHA
    2c8a9c2 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2026

  1. docs: add credential architecture internals doc (#3886)

    Adds docs/design/credential-architecture.md covering:
    - High-level credential loading flow (CredentialsProvider β†’ DefaultCredentialsLoader β†’ ICredentialSourceLoader)
    - Key interfaces and their assemblies
    - All built-in credential source loaders
    - CredentialDescription lifecycle (Initial β†’ Loaded/Skipped)
    - Token binding (Bearer vs mTLS PoP) flow
    - Credential wiring to MSAL detail
    - Extension points for custom loaders and assertion providers
    - Credential fallback chain semantics
    - End-to-end sequence diagrams for FIC+MI Bearer and Certificate mTLS PoP scenarios
    - Summary matrix of credential type Γ— token type compatibility
    
    Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    gladjohn and Copilot authored Jul 7, 2026
    Configuration menu
    Copy the full SHA
    84c7bd9 View commit details
    Browse the repository at this point in the history
  2. Potential fix for code scanning alert no. 35: Missing cross-site requ…

    …est forgery token validation (#3929)
    
    Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
    gladjohn and github-advanced-security[bot] authored Jul 7, 2026
    Configuration menu
    Copy the full SHA
    a4588a9 View commit details
    Browse the repository at this point in the history
  3. Register IAuthorizationHeaderProvider2 in DI (#3927)

    * Register IAuthorizationHeaderProvider2 in DI
    
    DefaultAuthorizationHeaderProvider implements both IAuthorizationHeaderProvider and
    IAuthorizationHeaderProvider2, but only v1 was registered - so resolving v2 directly
    returned nothing (internal callers only worked because they cast). Register v2 as the
    same instance (mirroring how ITokenAcquisitionInternal is exposed off ITokenAcquisition)
    in both the singleton and scoped paths, and remove it on the lifetime-mismatch re-registration.
    
    Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    
    * Add GetAuthorizationHeaderProvider2() to OWIN controllers (#3928)
    
    * Register IAuthorizationHeaderProvider2 in DI
    
    DefaultAuthorizationHeaderProvider implements both IAuthorizationHeaderProvider and
    IAuthorizationHeaderProvider2, but only v1 was registered - so resolving v2 directly
    returned nothing (internal callers only worked because they cast). Register v2 as the
    same instance (mirroring how ITokenAcquisitionInternal is exposed off ITokenAcquisition)
    in both the singleton and scoped paths, and remove it on the lifetime-mismatch re-registration.
    
    Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    
    * Add GetAuthorizationHeaderProvider2() to OWIN controllers
    
    OWIN controllers already get a one-liner for the v1 IAuthorizationHeaderProvider;
    this adds the same convenience for IAuthorizationHeaderProvider2 on both ApiController
    and ControllerBase, resolving it from the OWIN TokenAcquirerFactory service provider.
    
    Depends on IAuthorizationHeaderProvider2 being registered in DI.
    
    Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    neha-bhargava and Copilot authored Jul 7, 2026
    Configuration menu
    Copy the full SHA
    922beec View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2026

  1. Bump Microsoft.Identity.Client to 4.86.0 (#3931)

    * Bump Microsoft.Identity.Client to 4.86.0
    
    Update MicrosoftIdentityClientVersion and MicrosoftIdentityClientKeyAttestationVersion from 4.85.2 to the newly released 4.86.0.
    
    Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    
    * Handle MSAL 4.86 region outcome
    
    Map the new MSAL UserProvided region outcome to the existing abstractions region outcome so token metadata remains stable with Microsoft.Identity.Client 4.86.0.
    
    Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    
    Copilot-Session: 193b68e5-e60f-4aa3-937e-dae6d36d9111
    
    ---------
    
    Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    Co-authored-by: Bogdan Gavril <bogavril@microsoft.com>
    3 people authored Jul 9, 2026
    Configuration menu
    Copy the full SHA
    3c79dc9 View commit details
    Browse the repository at this point in the history
  2. Split PR pipeline into independent net8 stages; add MI E2E stage on M…

    …SALMSIV2 (#3933)
    
    * Split PR pipeline into independent net8 stages; add MI E2E stage on MSALMSIV2
    
    Build (full multi-TFM + unit tests) stays critical path; IntegrationTests,
    E2ETests (non-MI) and ManagedIdentityE2E run independently (dependsOn: []).
    MI tests run on the MSALMSIV2 VM pool with its assigned UAMI.
    
    Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    
    * Install global.json SDK on MSALMSIV2 MI stage to fix restore
    
    The MI stage only installed .NET 8, but global.json pins SDK 10.0.x, so
    dotnet restore failed with 'A compatible .NET SDK was not found'. Add
    UseDotNet useGlobalJson:true (keeping 8.0.x for the net8.0 test runtime).
    
    Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    iarekk and Copilot authored Jul 9, 2026
    Configuration menu
    Copy the full SHA
    01076c1 View commit details
    Browse the repository at this point in the history
  3. Run missing unit test projects in the ADO PR build (#3934)

    * Add missing unit test assemblies to ADO PR build
    
    The unit-test VSTest step only ran Microsoft.Identity.Web.Test.dll,
    skipping four projects the GitHub Action already covers: UI.Test,
    Sidecar.Tests (126 tests), OidcIdp and CustomSignedAssertion provider
    tests. All are built by the full solution build, so add them to the
    unit-test glob.
    
    Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    
    * Exclude Sidecar E2E/integration tests to match GitHub Action
    
    Sidecar.Tests contains SidecarEndpointsE2ETests and SidecarIntegrationTests
    that need a live sidecar and are filtered out in the GitHub Action. They
    failed on the hosted ADO agent. Add the same VSTest filter so only the
    in-memory Sidecar tests run, matching GH parity.
    
    Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    iarekk and Copilot authored Jul 9, 2026
    Configuration menu
    Copy the full SHA
    8c128e0 View commit details
    Browse the repository at this point in the history
  4. Revert PRs #3933 and #3934: restore single-job PR pipeline (#3936)

    * Initial plan
    
    * Revert PRs #3933 and #3934: restore single-job pipeline, aggregated test template, original MI client ID; delete 5 added template files
    
    ---------
    
    Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
    Copilot authored Jul 9, 2026
    Configuration menu
    Copy the full SHA
    f6d7aef View commit details
    Browse the repository at this point in the history
Loading