Skip to content

fix async call in cache write - #1043

Closed
jennyf19 wants to merge 2 commits into
masterfrom
jennyf/asyncCacheWrite
Closed

jennyf19 wants to merge 2 commits into
masterfrom
jennyf/asyncCacheWrite

Conversation

@jennyf19

@jennyf19 jennyf19 commented Mar 4, 2021

Copy link
Copy Markdown
Collaborator

for discussion.

@jennyf19

jennyf19 commented Mar 4, 2021

Copy link
Copy Markdown
Collaborator Author

henrikm (@henrik-me) i think we're still discussing this, but this branch has the latest that we (Jean-Marc Prieur (@jmprieur) ) discussed.

}
else
{
await DistributedCacheRemoveKeyAsync(cacheKey, startTicks).ConfigureAwait(false);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

await DistributedCacheRemoveKeyAsync(cacheKey, startTicks).ConfigureAwait(false); [](start = 16, length = 81)

should be an action, and the work should be added to an queue, and there should be an event processor to guarantee ordering of events. should do a bit more work here

@sonarqubecloud

sonarqubecloud Bot commented Mar 4, 2021

Copy link
Copy Markdown

@jennyf19

Copy link
Copy Markdown
Collaborator Author

not doing this.

@jennyf19 jennyf19 closed this Mar 10, 2021
@jennyf19
jennyf19 deleted the jennyf/asyncCacheWrite branch October 17, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants