Skip to content

Fix CMake build on a root folder that contains spaces - #11780

Merged
Nir-Az merged 6 commits into
realsenseai:developmentfrom
Tamir91:fix-bug-space-in-link
May 15, 2023
Merged

Nir-Az merged 6 commits into
realsenseai:developmentfrom
Tamir91:fix-bug-space-in-link

Conversation

@Tamir91

@Tamir91 Tamir91 commented May 8, 2023

Copy link
Copy Markdown
Contributor

Tracked on [LRS-779]

@Tamir91
Tamir91 requested a review from Nir-Az May 8, 2023 11:09
@Tamir91 Tamir91 added the python label May 8, 2023
@Tamir91
Tamir91 removed the request for review from Nir-Az May 8, 2023 11:10
Comment thread unit-tests/unit-test-config.py Resolved
Comment thread unit-tests/unit-test-config.py Resolved
Comment thread unit-tests/unit-test-config.py Resolved
@Nir-Az
Nir-Az requested a review from OhadMeir May 11, 2023 08:43
@Nir-Az Nir-Az changed the title Fixing bug space in link in Cmake file Fix CMake build on a root folder that contains spaces May 11, 2023
@Tamir91
Tamir91 requested a review from Nir-Az May 11, 2023 08:50

@Nir-Az Nir-Az left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's also have @OhadMeir inputs

Comment thread unit-tests/unit-test-config.py Resolved
@Nir-Az

Nir-Az commented May 14, 2023

Copy link
Copy Markdown
Collaborator

@OhadMeir ?

@OhadMeir

Copy link
Copy Markdown
Contributor

@OhadMeir ?

I tried it on Thursday and it did not work but could not share screen with Tamir due to technical issues. Will continue with him tomorrow.

We found one bug with Cmake that was fixed by adding a small change.

Co-Authored-By: Ohad Meir <100071798+OhadMeir@users.noreply.github.com>

@OhadMeir OhadMeir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works OK now

@Nir-Az
Nir-Az merged commit 0be8984 into realsenseai:development May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants