Repository navigation
Fix device init messages w/ multiple clients - #11930
Merged
Merged
Conversation
OhadMeir
reviewed
Jun 21, 2023
|
|
||
| Only one set of initialization messages can be sent at a time. I.e., if a new client is detected while initialization messages for a previous client are still outgoing, a new set of messages must go out but only once the previous set is finished. | ||
|
|
||
| While a set of initialization messages are outgoing, all other notifications must take a back seat and wait until the set is written out. |
Contributor
There was a problem hiding this comment.
I think that it is more important to send notifications to existing client than to new clients.
Contributor
There was a problem hiding this comment.
As discussed, current implementation writes all notification messages as a block of messages, other messages will be written after the block
Contributor
Author
There was a problem hiding this comment.
Agreed, but I don't think it's any big or long ask to send the init messages as one set without other messages interspersed in-between. It's how the current adapter/notification-server behaves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and:
Tracked on [LRS-797]