Skip to content

test-live-frames-fps time to measure based on fps - #12544

Merged
Nir-Az merged 2 commits into
realsenseai:developmentfrom
OhadMeir:Coverity
Jan 1, 2024
Merged

Nir-Az merged 2 commits into
realsenseai:developmentfrom
OhadMeir:Coverity

Conversation

@OhadMeir

Copy link
Copy Markdown
Contributor

Reducing the test time

@OhadMeir
OhadMeir requested a review from Nir-Az December 28, 2023 07:45
Comment thread unit-tests/live/frames/test-fps.py Outdated
# test:device each(D400*)
# test:donotrun:!nightly
# test:timeout 250
# test:timeout 154

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test took 140.40848207473755 seconds
Do you think 154 is enough?
Since LibCI default timeout is 250 (IIRC) we can drop this line at all, we only need it when we want to increase , right?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On win it took more
test took 151.15837216377258 seconds

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is from my run with nightly context, the PR run skip this test :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the line. Looks OK in CI


delta_Hz = 1
tested_fps = [6, 15, 30, 60, 90]
time_to_test_fps = [20, 13, 10, 5, 4]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how you chose those numbers :)
Maybe you can add a comment.

I tried following some logic that you ask for 300 frames but it's not persistent.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No explicit rule. On one hand I wanted enough frames, around 300 looked like a good number. On the other hand I wanted to reduce the test time so on low FPS I settled for less frames.

@Nir-Az
Nir-Az merged commit 956347f into realsenseai:development Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants