Skip to content

DDS ROI support; enums in adapter - #12819

Merged
maloel merged 8 commits into
realsenseai:developmentfrom
maloel:origin-roi
Apr 11, 2024
Merged

maloel merged 8 commits into
realsenseai:developmentfrom
maloel:origin-roi

Conversation

@maloel

@maloel maloel commented Apr 2, 2024 •

Copy link
Copy Markdown
Contributor
  • dds sensor now extends to roi_sensor if an option exists that's named "Region of Interest"
    • this sensor directly translates set()/get() to this option
  • add dds_rect_option, communicated as an array [x1,y1,x2,y2]
  • add RS2_OPTION_REGION_OF_INTEREST, which is skipped by the Viewer
    • add a as_rect to union inside rs2_option_value
  • add ROI support to dds-adapter

Tracked on [RSDEV-1904]

Also:

  • move legacy set-option type conversion to rs-dds-option, as some options (e.g., error-polling) are set as floats from within librealsense
  • guard against exceptions in options-changed callbacks
  • add enum support to dds-adapter (enum values weren't transmitted before, so they weren't enums in the client)

@maloel
maloel requested a review from OhadMeir April 2, 2024 14:30
@maloel
maloel requested a review from qtsleng April 2, 2024 14:40
Comment thread third-party/realdds/src/dds-option.cpp Resolved
Comment thread src/dds/rs-dds-option.cpp Resolved
Comment thread src/dds/rs-dds-sensor-proxy.cpp Resolved
… against exceptions in options-changed callback
@maloel
maloel requested a review from OhadMeir April 10, 2024 05:41
@maloel
maloel merged commit c17054a into realsenseai:development Apr 11, 2024
@maloel
maloel deleted the origin-roi branch April 11, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants