Skip to content

Update ImGui v1.90.9 - #13392

Merged
Nir-Az merged 12 commits into
realsenseai:developmentfrom
Noy-Zini:Update_ImGui_v1.90.9
Dec 18, 2024
Merged

Nir-Az merged 12 commits into
realsenseai:developmentfrom
Noy-Zini:Update_ImGui_v1.90.9

Conversation

@Noy-Zini

@Noy-Zini Noy-Zini commented Oct 1, 2024

Copy link
Copy Markdown
Contributor

Traced on: [LRS-1129]

Comment thread common/measurement.cpp Resolved
Comment thread common/ux-alignment.cpp Resolved
Comment thread common/ux-alignment.cpp Resolved
Comment thread common/ux-window.cpp Resolved
Comment thread common/ux-window.cpp Resolved
Comment thread common/ux-window.cpp Resolved
Comment thread common/ux-window.cpp Resolved
Comment thread examples/align-advanced/CMakeLists.txt Resolved
Comment thread examples/align-advanced/CMakeLists.txt Resolved
Comment thread examples/align-advanced/CMakeLists.txt Resolved
Comment thread third-party/imgui/realsense_imgui.cpp Resolved
Comment thread third-party/imgui/realsense_imgui.h Resolved
@Nir-Az

Nir-Az commented Oct 6, 2024

Copy link
Copy Markdown
Collaborator

Note that once ready we will have to make a UI sanity to this change.
Including online updates windows, calibration windows and more

@Noy-Zini
Noy-Zini force-pushed the Update_ImGui_v1.90.9 branch from 5ea88b8 to 48807d1 Compare October 6, 2024 13:01
Comment thread common/option-model.cpp Resolved
Comment thread common/option-model.cpp Resolved
Comment thread common/subdevice-model.cpp Resolved
Comment thread common/ux-window.cpp Resolved
Comment thread common/viewer.cpp Resolved
Comment thread examples/align-advanced/CMakeLists.txt Resolved
Comment thread examples/align-gl/CMakeLists.txt Resolved
Comment thread examples/align-gl/rs-align-gl.cpp Resolved
Comment thread examples/align-gl/rs-align-gl.cpp Resolved
Comment thread examples/example-imgui.hpp Resolved
Comment thread examples/example-imgui.hpp Resolved
Comment thread third-party/imgui/realsense_imgui.cpp Resolved
@Noy-Zini
Noy-Zini force-pushed the Update_ImGui_v1.90.9 branch from b1881af to dd72548 Compare November 19, 2024 12:37
@Noy-Zini
Noy-Zini force-pushed the Update_ImGui_v1.90.9 branch from 844ac13 to 54a0dc3 Compare November 20, 2024 12:10
Comment thread common/ux-alignment.cpp Resolved
@Noy-Zini
Noy-Zini force-pushed the Update_ImGui_v1.90.9 branch 4 times, most recently from 79ed478 to 86d8f64 Compare November 26, 2024 14:02
@Noy-Zini
Noy-Zini force-pushed the Update_ImGui_v1.90.9 branch from 86d8f64 to 4ed121d Compare November 26, 2024 14:20
@Noy-Zini
Noy-Zini requested a review from Nir-Az November 26, 2024 15:47
Comment thread examples/example-imgui.hpp Resolved
Comment thread third-party/imgui/realsense_imgui.h Resolved
Comment thread third-party/imgui/realsense_imgui.h Resolved
Comment thread tools/depth-quality/CMakeLists.txt Resolved
@Noy-Zini
Noy-Zini force-pushed the Update_ImGui_v1.90.9 branch from 00a7344 to 41a586b Compare December 4, 2024 14:08
@Noy-Zini
Noy-Zini requested a review from Nir-Az December 8, 2024 10:37
Comment thread common/device-model.cpp Outdated
if (ImGui::ButtonEx(record_button_name.c_str(), device_panel_icons_size, (disable_record_button_logic(is_streaming, is_playback_device)) ? ImGuiButtonFlags_Disabled : 0))
bool button_disabled = disable_record_button_logic(is_streaming, is_playback_device);
if (button_disabled)
ImGui::PushStyleColor(ImGuiCol_Text,ImVec4(0.5f,0.5f,0.5f,1.f));

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the flag ImGuiButtonFlags_Disabled was removed so I used ImGuiItemFlags_Disabled flag instead and it wasn't changing the button color (to dark gray). I searched more and found ImGui::BeginDisabled() function that does it better and used it instead.

Comment thread common/device-model.cpp Outdated
if (button_disabled)
ImGui::PushStyleColor(ImGuiCol_Text,ImVec4(0.5f,0.5f,0.5f,1.f));

if (ImGui::ButtonEx(record_button_name.c_str(), device_panel_icons_size, (disable_record_button_logic(is_streaming, is_playback_device)) ? ImGuiItemFlags_Disabled : 0))

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have it on button_disabled no?

@Noy-Zini
Noy-Zini force-pushed the Update_ImGui_v1.90.9 branch from a64e4a3 to c6188ef Compare December 10, 2024 13:00
@Noy-Zini
Noy-Zini requested a review from Nir-Az December 10, 2024 13:37
@Nir-Az
Nir-Az merged commit 5b1ea01 into realsenseai:development Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants