Skip to content

fix compute_progress() bug; improve D500 FW update output - #13580

Merged
maloel merged 2 commits into
realsenseai:developmentfrom
maloel:development
Dec 9, 2024
Merged

maloel merged 2 commits into
realsenseai:developmentfrom
maloel:development

Conversation

@maloel

@maloel maloel commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

Now that D500 FW update works, did some more testing and noticed the progress messages were not good. Fixed a bug. Improved. Added some info messages and improved flow readability (with debug).

Tracked on [RSDEV-2955]

@maloel maloel added the bug label Dec 5, 2024
@maloel
maloel requested a review from OhadMeir December 5, 2024 17:48
@Nir-Az
Nir-Az requested review from remibettan and removed request for OhadMeir December 5, 2024 18:40
@Nir-Az

Nir-Az commented Dec 5, 2024

Copy link
Copy Markdown
Collaborator

Hey,
Since some of the original code for d500 was implemented by Remi and we need to make sure no other D500 regression, I switched the review to Remi

@maloel

maloel commented Dec 5, 2024

Copy link
Copy Markdown
Contributor Author

Hey, Since some of the original code for d500 was implemented by Remi and we need to make sure no other D500 regression, I switched the review to Remi

No problem. But I didn't change any logic.

{
auto percentage_of_transfer = i;
auto progress_for_bar = compute_progress(static_cast<float>(percentage_of_transfer), 20.f, 100.f, 5.f) / 100.f;
auto progress_for_bar = compute_progress(percentage_of_transfer / 100.f, 20.f, 100.f, 0.f) / 100.f;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check that this change is OK both when working with viewer and rs-fw-update tools.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested :)

@remibettan remibettan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but please check the comment before merging

@maloel
maloel merged commit 16f96af into realsenseai:development Dec 9, 2024
@maloel
maloel deleted the development branch December 9, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants