Skip to content

Fix for #185 - #209

Closed
kirill-konshin wants to merge 1 commit into
JakeChampion:masterfrom
kirill-konshin:master
Closed

kirill-konshin wants to merge 1 commit into
JakeChampion:masterfrom
kirill-konshin:master

Conversation

@kirill-konshin

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread test/test.js Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you wanted to use assert.equal here. Also, to compare two hashes which are supposed to be the same, you could use assert.deepEqual(jsons[0], jsons[1])

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm more used to expect(...).to... syntax. Give me a sec, I'll upload update.

@mislav

mislav commented Sep 29, 2015

Copy link
Copy Markdown
Contributor

It's also necessary to manually run these tests against native fetch implementation in latest Chrome and Firefox (although Chrome might be covered by Saucelabs in CI, unless that's busted, which it often is). Please confirm when you've done that; thanks!

@kirill-konshin
kirill-konshin force-pushed the master branch 2 times, most recently from 7157406 to a0cd215 Compare September 29, 2015 22:10
@kirill-konshin

Copy link
Copy Markdown
Contributor Author

I've uploaded all changes based on your comments. Yes, I confirm, that I've run tests for both native and polyfill. To do that I had to insert a line window.fetch = null. I suggest to create a second test.html with that specific case.

Also I had to skip the test of arrayBuffer under Phantom... But it's what is usually done in your tests :)

Some test runs are failing on Travis:

["Windows 7", "googlechrome", ""]
"Invalid tunnel_identifier 378.2"
./script/saucelabs-result:13:in `<main>': undefined method `+' for nil:NilClass (NoMethodError)

How to fix this?

@mislav mislav mentioned this pull request Oct 12, 2015
@mislav mislav closed this in 11f0e9a Oct 12, 2015
@mislav

mislav commented Oct 12, 2015

Copy link
Copy Markdown
Contributor

The "Invalid tunnel_identifier" error is know to us and we're working on fixing it. It's not your fault.

I've merged your changes, thanks. I've got some feedback for you to keep in mind for your future contributins to projects:

  • We like to see more descriptive pull request titles and messages. And instead of putting Fix for #185 in the title, put Fixes #185 in the pull request message so that the referenced issue gets auto-closed when the PR is merged.
  • We like to see more descriptive commit messages. Your commit was simply Fix for #185, but when listing commits on the command-line with git log, that commit title is not very friendly.
  • I had to amend your commit to fit our coding style. For instance, we don't use semicolons. When adding code, always look what the coding style in the rest of the codebase is like.
  • The Request.clone() method was broken (it didn't copy the body properly) and we didn't catch that because it didn't have tests. I've added tests and fixed the method. fd362dd

@kirill-konshin

Copy link
Copy Markdown
Contributor Author

Thanks for your recommendations.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants