Repository navigation
Fix for #185 - #209
Fix for #185#209kirill-konshin wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
I think you wanted to use assert.equal here. Also, to compare two hashes which are supposed to be the same, you could use assert.deepEqual(jsons[0], jsons[1])
There was a problem hiding this comment.
Thanks, I'm more used to expect(...).to... syntax. Give me a sec, I'll upload update.
|
It's also necessary to manually run these tests against native |
7157406 to
a0cd215
Compare
a0cd215 to
e6f6e0e
Compare
|
I've uploaded all changes based on your comments. Yes, I confirm, that I've run tests for both native and polyfill. To do that I had to insert a line Also I had to skip the test of arrayBuffer under Phantom... But it's what is usually done in your tests :) Some test runs are failing on Travis: How to fix this? |
|
The "Invalid tunnel_identifier" error is know to us and we're working on fixing it. It's not your fault. I've merged your changes, thanks. I've got some feedback for you to keep in mind for your future contributins to projects:
|
|
Thanks for your recommendations. |
No description provided.