Repository navigation
Add fit_data_fraction and cache_path to KMeansStage - #1927
Merged
Merged
Conversation
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
sarahyurick
commented
May 5, 2026
Comment on lines
+208
to
+210
| if self.cache_path is not None: | ||
| cp.save(f"{self.cache_path}/kmeans_centroids.npy", self.kmeans.cluster_centers_) | ||
| logger.info(f"Saved {self.n_clusters} KMeans centroids to {self.cache_path}/kmeans_centroids.npy") |
Contributor
Author
There was a problem hiding this comment.
Could there be a race condition here?
Comment on lines
+303
to
+305
| if self.cache_path is not None: | ||
| cp.save(f"{self.cache_path}/kmeans_centroids.npy", self.kmeans.cluster_centers_) | ||
| logger.info(f"Saved {self.n_clusters} KMeans centroids to {self.cache_path}/kmeans_centroids.npy") |
Contributor
Author
There was a problem hiding this comment.
Same comment as above.
7 tasks done
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
praateekmahajan
approved these changes
May 7, 2026
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
2 of 22 tasks
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
fit_data_fractionand/orcache_pathparameters throughSemanticDeduplicationWorkflow