Repository navigation
ci: validate release branch-rules - #2009
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
e9ad149 to
ba5861a
Compare
|
/ok to test ba5861a |
|
/ok to test 7f53a0c |
|
/ok to test b83915a |
|
/ok to test 1d2f37a |
|
/ok to test 4b28945 |
|
/ok to test b373488 |
|
/ok to test d719eff |
|
/ok to test 4447c24 |
…anch protection) Companion PR to NVIDIA-NeMo/FW-CI-templates#480, which mirrors the branch-protection rule of `[rv][0-9].[0-9].[0-9]` onto `deploy-release/*` so the validate-only release rehearsal is gated by the same required status checks as a real release. Pinned to commit f680963ed397a4ff0cd4c983a3a3071c209e5e77 on `ko3n1g/feat/mirror-release-branch-protection`. Re-pin to a released tag once FW-CI-templates#480 lands. Signed-off-by: oliver könig <okoenig@nvidia.com>
|
/ok to test 372deef |
Signed-off-by: oliver könig <okoenig@nvidia.com>
|
/ok to test 2694fde |
Signed-off-by: oliver könig <okoenig@nvidia.com>
|
/ok to test d55bac7 |
Signed-off-by: oliver könig <okoenig@nvidia.com>
|
/ok to test 71a9b8d |
Signed-off-by: oliver könig <okoenig@nvidia.com>
|
/ok to test dd5fb39 |
Greptile SummaryThis PR bumps the FW-CI-templates reusable-workflow pin in
Confidence Score: 4/5The workflow change is a one-line template bump; the new behaviour lives entirely in the upstream reusable workflow and depends on bot permissions configured outside this repo. The change is minimal and well-scoped. The only risk is that v1.4.0 introduces more than just the branch-protection mirror (it is a 4-minor-version jump from v1.0.0), and any breaking changes in the intermediate versions would silently affect the release pipeline. The PR description also refers to pinning an unmerged SHA while the diff shows an official tag, suggesting the description was not updated after the upstream PR landed. .github/workflows/release.yml — verify that v1.4.0 of FW-CI-templates does not introduce any incompatible input/output changes relative to the v1.0.0 interface this workflow was written against. Important Files Changed
Sequence DiagramsequenceDiagram
participant Caller as release.yml (curator)
participant Template as FW-CI-templates _release_library.yml@v1.4.0
participant Bot as nemo-automation-bot (GitHub App)
participant GH as GitHub API
Caller->>Template: "uses: ...@v1.4.0 (secrets: inherit, app-id)"
Template->>Bot: generate app token
Bot-->>Template: app token
Template->>Template: run validate / bump jobs
Template->>GH: "Mirror branch-protection rule deploy-release/* to [rv][0-9].[0-9].[0-9]"
GH-->>Template: rule updated
Template->>GH: open bump PR
GH-->>Caller: required-checks enforced on bump PR
Reviews (1): Last reviewed commit: "ci: re-pin FW-CI-templates from SHA to v..." | Re-trigger Greptile |
| release: | ||
| if: '!cancelled()' | ||
| uses: NVIDIA-NeMo/FW-CI-templates/.github/workflows/_release_library.yml@v1.0.0 | ||
| uses: NVIDIA-NeMo/FW-CI-templates/.github/workflows/_release_library.yml@v1.4.0 |
There was a problem hiding this comment.
PR description references an unmerged SHA, but the diff uses a tag
The PR description says the pin is to the raw commit 042e967e4ac9652c324cbd5b78fd126c089aec6c (head of ko3n1g/feat/mirror-release-branch-protection) and calls this a "draft + do not merge" PR. The actual diff, however, uses the official tag v1.4.0. If v1.4.0 already includes the FW-CI-templates#480 changes, the description is stale and should be updated to reflect that this is ready to merge. If the tag was applied prematurely, the pin should be re-verified against the intended upstream state.
Claude summary
Companion to NVIDIA-NeMo/FW-CI-templates#480, which mirrors the branch-protection rule of
[rv][0-9].[0-9].[0-9]ontodeploy-release/*so the validate-only release rehearsal is gated by the same required status checks as a real release.Change
Bumps the FW-CI-templates pin in
release.yamlto commit042e967e4ac9652c324cbd5b78fd126c089aec6c(the head ofko3n1g/feat/mirror-release-branch-protectionon FW-CI-templates).What's being validated
After merge of FW-CI-templates#480, a workflow-dispatch of
release.yamlwithdry-run: trueshould:bump-next-version.deploy-release/*rule on this repo to match[rv][0-9].[0-9].[0-9].Nemo_CICD_Test(or the repo's equivalent) shown as a required check.Prerequisites
The
nemo-automation-botGitHub App must holdadministration: writeat the org installation, otherwise the mirror step fails the bump.Rollout
This PR is draft + do not merge — pinned to an unmerged SHA. Once FW-CI-templates#480 lands and ships in a new tag, re-pin to that tag and merge.