Skip to content

ci: validate release branch-rules - #2009

Merged
ko3n1g merged 5 commits into
mainfrom
ko3n1g/ci/pin-fw-ci-pr-480
May 27, 2026
Merged

ko3n1g merged 5 commits into
mainfrom
ko3n1g/ci/pin-fw-ci-pr-480

Conversation

@ko3n1g

@ko3n1g ko3n1g commented May 22, 2026

Copy link
Copy Markdown
Contributor
Claude summary

Companion to NVIDIA-NeMo/FW-CI-templates#480, which mirrors the branch-protection rule of [rv][0-9].[0-9].[0-9] onto deploy-release/* so the validate-only release rehearsal is gated by the same required status checks as a real release.

Change

Bumps the FW-CI-templates pin in release.yaml to commit 042e967e4ac9652c324cbd5b78fd126c089aec6c (the head of ko3n1g/feat/mirror-release-branch-protection on FW-CI-templates).

What's being validated

After merge of FW-CI-templates#480, a workflow-dispatch of release.yaml with dry-run: true should:

  1. Run the new "Mirror branch protection" step in bump-next-version.
  2. Update the deploy-release/* rule on this repo to match [rv][0-9].[0-9].[0-9].
  3. Open the bump PR with Nemo_CICD_Test (or the repo's equivalent) shown as a required check.
  4. Block merge of the bump until the required checks pass.

Prerequisites

The nemo-automation-bot GitHub App must hold administration: write at the org installation, otherwise the mirror step fails the bump.

Rollout

This PR is draft + do not merge — pinned to an unmerged SHA. Once FW-CI-templates#480 lands and ships in a new tag, re-pin to that tag and merge.

@copy-pr-bot

copy-pr-bot Bot commented May 22, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@ko3n1g

ko3n1g commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test ba5861a

@ko3n1g

ko3n1g commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 7f53a0c

@ko3n1g

ko3n1g commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test b83915a

@ko3n1g

ko3n1g commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 1d2f37a

@ko3n1g

ko3n1g commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 4b28945

@ko3n1g

ko3n1g commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test b373488

@ko3n1g

ko3n1g commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test d719eff

2 similar comments
@ko3n1g

ko3n1g commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test d719eff

@ko3n1g

ko3n1g commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test d719eff

@ko3n1g

ko3n1g commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 4447c24

…anch protection)

Companion PR to NVIDIA-NeMo/FW-CI-templates#480, which mirrors the
branch-protection rule of `[rv][0-9].[0-9].[0-9]` onto `deploy-release/*` so
the validate-only release rehearsal is gated by the same required status
checks as a real release.

Pinned to commit f680963ed397a4ff0cd4c983a3a3071c209e5e77 on `ko3n1g/feat/mirror-release-branch-protection`.
Re-pin to a released tag once FW-CI-templates#480 lands.

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 372deef

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 2694fde

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented May 25, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test d55bac7

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented May 25, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 71a9b8d

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test dd5fb39

@greptile-apps

greptile-apps Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR bumps the FW-CI-templates reusable-workflow pin in release.yml from v1.0.0 to v1.4.0, enabling the new "Mirror branch protection" step that keeps the deploy-release/* branch-protection rule in sync with [rv][0-9].[0-9].[0-9] so dry-run release rehearsals are gated by the same required status checks as real releases.

  • Single-line change in .github/workflows/release.yml: @v1.0.0 → @v1.4.0; all other workflow inputs and secrets remain unchanged.
  • Prerequisite (out-of-band): nemo-automation-bot must hold administration: write at the org installation — this is not surfaced in the workflow YAML but is required for the new mirror step to succeed.

Confidence Score: 4/5

The workflow change is a one-line template bump; the new behaviour lives entirely in the upstream reusable workflow and depends on bot permissions configured outside this repo.

The change is minimal and well-scoped. The only risk is that v1.4.0 introduces more than just the branch-protection mirror (it is a 4-minor-version jump from v1.0.0), and any breaking changes in the intermediate versions would silently affect the release pipeline. The PR description also refers to pinning an unmerged SHA while the diff shows an official tag, suggesting the description was not updated after the upstream PR landed.

.github/workflows/release.yml — verify that v1.4.0 of FW-CI-templates does not introduce any incompatible input/output changes relative to the v1.0.0 interface this workflow was written against.

Important Files Changed

Filename Overview
.github/workflows/release.yml Single-line version bump of the FW-CI-templates reusable workflow reference from v1.0.0 to v1.4.0; no structural changes to the workflow.

Sequence Diagram

sequenceDiagram
    participant Caller as release.yml (curator)
    participant Template as FW-CI-templates _release_library.yml@v1.4.0
    participant Bot as nemo-automation-bot (GitHub App)
    participant GH as GitHub API

    Caller->>Template: "uses: ...@v1.4.0 (secrets: inherit, app-id)"
    Template->>Bot: generate app token
    Bot-->>Template: app token
    Template->>Template: run validate / bump jobs
    Template->>GH: "Mirror branch-protection rule deploy-release/* to [rv][0-9].[0-9].[0-9]"
    GH-->>Template: rule updated
    Template->>GH: open bump PR
    GH-->>Caller: required-checks enforced on bump PR
Loading

Reviews (1): Last reviewed commit: "ci: re-pin FW-CI-templates from SHA to v..." | Re-trigger Greptile

release:
if: '!cancelled()'
uses: NVIDIA-NeMo/FW-CI-templates/.github/workflows/_release_library.yml@v1.0.0
uses: NVIDIA-NeMo/FW-CI-templates/.github/workflows/_release_library.yml@v1.4.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 PR description references an unmerged SHA, but the diff uses a tag

The PR description says the pin is to the raw commit 042e967e4ac9652c324cbd5b78fd126c089aec6c (head of ko3n1g/feat/mirror-release-branch-protection) and calls this a "draft + do not merge" PR. The actual diff, however, uses the official tag v1.4.0. If v1.4.0 already includes the FW-CI-templates#480 changes, the description is stale and should be updated to reflect that this is ready to merge. If the tag was applied prematurely, the pin should be re-verified against the intended upstream state.

This branch was previously deployed

3 inactive deployments
public — dd5fb393 Deployed May 27, 2026 by copy-pr-bot[bot] via release / finalize / publish-docs #153
nemo-ci — dd5fb393 Deployed May 27, 2026 by copy-pr-bot[bot] via L0_Unit_Test_GPU-text #4516
test — dd5fb393 Deployed May 27, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #4516
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants