Skip to content

Rename macOS hardware decoder label to "Apple VideoToolbox" - #6003

Closed
geekrebel wants to merge 1 commit into
OpenShot:developfrom
geekrebel:macos-hw-decoder-label
Closed

geekrebel wants to merge 1 commit into
OpenShot:developfrom
geekrebel:macos-hw-decoder-label

Conversation

@geekrebel

Copy link
Copy Markdown
Contributor

The macOS entry in the Hardware Decoder Mode dropdown is labelled simply
"MacOS", which is inconsistent with the other platform labels ("Linux VA-API",
"Nvidia NVDEC", "Windows D3D11", "Intel QSV", ...). This renames it to
"Apple VideoToolbox" and updates the two places that match on the English
label (preferences.py icon map, about.py short performance-line label).

The underlying hw-decoder integer (5) is unchanged, so existing user settings
continue to resolve to the same VideoToolbox path in libopenshot.

Scope is intentionally small to stay easy to review; this is the first in a
planned series of small Apple Silicon PRs (next: arch-aware DMG naming in
installer/build_server.py, and replacing the hard-coded /usr/local/Cellar
Python 3.7 path in installer/build-mac-dmg.sh).

Note for follow-up: the icon-matching block at preferences.py:448+ has a
latent bug - it checks i == <int> as a fallback, but no hw-decoder value
in _default.settings actually carries an "icon" field, so icons only resolve
by English label. Worth a separate PR to add "icon" fields to the settings
entries.

…oToolbox" so it matches the naming convention of the other hardware acceleration entries (e.g. "Linux VA-API", "Nvidia NVDEC", "Intel QSV"). The underlying decoder integer value (5) is unchanged, so existing user preferences continue to resolve to the same VideoToolbox path in libopenshot. The short label shown on the About dialog's performance line is also updated to "VideoToolbox".

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@geekrebel

Copy link
Copy Markdown
Contributor Author

Hi @jonoomph, I noticed this one was closed at the same time the others in the set were merged, without a note. Was that intentional? If you'd rather keep the current "MacOS" label, that's completely fine; I just wanted to make sure it wasn't closed by accident.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant