Repository navigation
Conversation
…14018) Since JLine was removed in 3.10.1, Maven turns colors on for a Windows console only when an environment variable shows the terminal handles ANSI escapes (WT_SESSION, ConEmuANSI, ANSICON, TERM_PROGRAM=vscode or TERM). A shell that Windows hands over to Windows Terminal, for example one launched by GitHub Desktop, does not get WT_SESSION, so colors were off even though the terminal renders them. Windows 11 uses Windows Terminal as the default terminal, and the legacy console host is opt-in there, so trust an interactive console on Windows 11 too. Other Windows versions keep the environment variable checks, as the legacy console host does not process escapes unless the program enables it. Windows 11 users who made the legacy console their default again can use --color=never.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14018
Since JLine was removed in 3.10.1, Maven turns colors on for a Windows console only when an environment variable shows the terminal handles ANSI escapes (WT_SESSION, ConEmuANSI, ANSICON, TERM_PROGRAM=vscode or TERM). A shell that Windows hands over to Windows Terminal, for example one launched by GitHub Desktop, does not get WT_SESSION, so colors were off even though the terminal renders them.
Windows 11 uses Windows Terminal as the default terminal, and the legacy console host is opt-in there, so trust an interactive console on Windows 11 too. Other Windows versions keep the environment variable checks, as the legacy console host does not process escapes unless the program enables it. Windows 11 users who made the legacy console their default again can use --color=never.