Skip to content

fix(extensions): install command chains without the make plugin - #6563

Open
skdas20 wants to merge 1 commit into
canonical:mainfrom
skdas20:fix/desktop-extensions-without-make
Open

skdas20 wants to merge 1 commit into
canonical:mainfrom
skdas20:fix/desktop-extensions-without-make

Conversation

@skdas20

@skdas20 skdas20 commented Nov 14, 2026

Copy link
Copy Markdown

Fixes #6479.

The gnome, kde-neon, kde-neon-6, kde-neon-qt6 and gpu extensions used the make plugin to install their command-chain scripts, which adds gcc and make to the build packages. That fails when gcc can't be installed, as in the cross-compiling case in the issue.

As @mr-cal suggested there, the Makefiles were only copying scripts with mode 755 (and, for the GPU wrapper, substituting the interface name with sed). This replaces them with the nil plugin and an override-build that runs the same install/sed commands, and removes the three Makefiles. The KDE PLATFORM_PLUG make parameter wasn't used by its Makefile, so it's dropped.

I checked that the new commands produce the same files as make install with the old Makefiles (same paths, contents and modes) for the GNOME and KDE command chains and for the GPU wrapper with graphics-core22, gpu-2404 and gpu-2604.

ROS 2 extensions still use the make plugin; I left them out to keep this focused on the desktop extensions.


  • I've followed the contribution guidelines.
  • I've signed the CLA.
  • I've successfully run make lint && make test. (ran tests/unit/extensions (162 passed) and ruff check/format on the changed files; the full suite needs python-apt, which isn't available in my environment)
  • I've added or updated any relevant documentation. (no user-facing docs change)
  • In documents I changed, I added a meta description if one was missing. (n/a)
  • I've updated the relevant release notes. (happy to add an entry once you tell me which release this targets)

🤖 Generated with Claude Code

The gnome, kde-neon, kde-neon-6, kde-neon-qt6 and gpu extensions used
the make plugin to install their command-chain scripts. The make plugin
adds gcc and make as build packages, which fails when gcc cannot be
installed, for example when cross-compiling in destructive mode.

The Makefiles only copied scripts with mode 755 (and, for the GPU
wrapper, substituted the interface name), so install them with the nil
plugin and an override-build script instead, and remove the Makefiles.
The installed files are identical.

Fixes canonical#6479

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@skdas20
skdas20 requested a review from mr-cal as a code owner November 14, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

craft_parts.packages.deb.Ubuntu wants gcc, but it is not installable (Depends: binutils)

1 participant