Repository navigation
Conversation
The gnome, kde-neon, kde-neon-6, kde-neon-qt6 and gpu extensions used the make plugin to install their command-chain scripts. The make plugin adds gcc and make as build packages, which fails when gcc cannot be installed, for example when cross-compiling in destructive mode. The Makefiles only copied scripts with mode 755 (and, for the GPU wrapper, substituted the interface name), so install them with the nil plugin and an override-build script instead, and remove the Makefiles. The installed files are identical. Fixes canonical#6479 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6479.
The gnome, kde-neon, kde-neon-6, kde-neon-qt6 and gpu extensions used the
makeplugin to install their command-chain scripts, which addsgccandmaketo the build packages. That fails when gcc can't be installed, as in the cross-compiling case in the issue.As @mr-cal suggested there, the Makefiles were only copying scripts with mode 755 (and, for the GPU wrapper, substituting the interface name with
sed). This replaces them with thenilplugin and anoverride-buildthat runs the sameinstall/sedcommands, and removes the three Makefiles. The KDEPLATFORM_PLUGmake parameter wasn't used by its Makefile, so it's dropped.I checked that the new commands produce the same files as
make installwith the old Makefiles (same paths, contents and modes) for the GNOME and KDE command chains and for the GPU wrapper withgraphics-core22,gpu-2404andgpu-2604.ROS 2 extensions still use the make plugin; I left them out to keep this focused on the desktop extensions.
make lint && make test. (rantests/unit/extensions(162 passed) and ruff check/format on the changed files; the full suite needs python-apt, which isn't available in my environment)🤖 Generated with Claude Code