Skip to content

feat(next)!: split remove into 2 commands - #1545

Merged
eoghanriley merged 14 commits into
mainfrom
eoghanriley/cli-320
Sep 14, 2026
Merged

eoghanriley merged 14 commits into
mainfrom
eoghanriley/cli-320

Conversation

@eoghanriley

@eoghanriley eoghanriley commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Description

This PR splits uds bundle remove into two commands, following the split that was done with deploy. uds bundle remove handles artifacts while uds bundle dev remove handle hcl files and directories.

Related Issue

Fixes CLI-320

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@eoghanriley eoghanriley changed the title Eoghanriley/cli 320 feat(next)!: split bundle remove into dev remove Sep 8, 2026
@eoghanriley eoghanriley changed the title feat(next)!: split bundle remove into dev remove feat(next)!: split remove into dev remove and remove Sep 8, 2026
@eoghanriley eoghanriley changed the title feat(next)!: split remove into dev remove and remove feat(next)!: split remove into 2 commands Sep 8, 2026
@eoghanriley
eoghanriley marked this pull request as ready for review September 9, 2026 13:46
@eoghanriley
eoghanriley requested a review from a team as a code owner September 9, 2026 13:46
@greptile-apps

greptile-apps Bot commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge, with no outstanding correctness, security, or repository-rule violations identified.

Summary

  • Adds uds bundle dev remove for local HCL bundle definitions.
  • Restricts uds bundle remove to local or OCI artifacts with signature-verification policy.
  • Updates removal tests, integration helpers, command guidance, and documentation.
  • Corrects the malformed replacement command identified during the previous review.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  U[User] --> S{Removal source}
  S -->|HCL file or directory| D[uds bundle dev remove]
  S -->|tar.zst or OCI reference| A[uds bundle remove]
  D --> W[Warn that provenance and signature verification are unavailable]
  A --> V[Apply artifact signature-verification policy]
  W --> R[Validate dependencies and remove packages]
  V --> R
Loading

Comment thread internal/cli/bundle/remove.go Resolved

@chance-coleman chance-coleman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, two smaller comments and i'd be happy to approve.

Comment thread tests/testutil/cluster.go Resolved
Comment thread internal/cli/bundle/remove.go Resolved
chance-coleman
chance-coleman previously approved these changes Sep 11, 2026
joelmccoy
joelmccoy previously approved these changes Sep 14, 2026

@joelmccoy joelmccoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - i added a comment to reduce some code duplication, you can take it or leave it

Comment thread internal/cli/bundle/dev_remove.go Resolved
@eoghanriley
eoghanriley merged commit 6160987 into main Sep 14, 2026
41 checks passed
@eoghanriley
eoghanriley deleted the eoghanriley/cli-320 branch September 14, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants