Skip to content

fix(legacy): don't print full bundle config in debug log message - #1557

Merged
joelmccoy merged 1 commit into
mainfrom
joel/cli-342
Sep 15, 2026
Merged

joelmccoy merged 1 commit into
mainfrom
joel/cli-342

Conversation

@joelmccoy

@joelmccoy joelmccoy commented Sep 15, 2026 •

Copy link
Copy Markdown
Member

Description

A bug fix in CLI legacy logic to limit printing sensitive info in logs. Updated the debug log message to only print a subset of the UDSConfig. Updated e2e tests to catch this better in the future.

Related Issue

Fixes CLI-342

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@joelmccoy
joelmccoy requested a review from a team as a code owner September 15, 2026 19:31
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-15T19:35:07.978778Z 1ce10f0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@joelmccoy joelmccoy changed the title fix: don't print full bundle config in debug log message fix(legacy): don't print full bundle config in debug log message Sep 15, 2026
@greptile-apps

greptile-apps Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no actionable correctness, security, or repository-rule violations identified.

Summary

This PR prevents legacy bundle initialization from serializing the complete bundle configuration into debug logs.

  • Replaces full-config logging with selected deployment and creation metadata.
  • Extends variable end-to-end coverage to verify sensitive values are absent from stdout, stderr, and generated log files.
  • Updates log-file path extraction to handle multiline and formatted command output.

Reviews (1) · Last reviewed commit: "fix: don't print full bundle config in d..."

@joelmccoy
joelmccoy merged commit f594cde into main Sep 15, 2026
29 checks passed
@joelmccoy
joelmccoy deleted the joel/cli-342 branch September 15, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants