Skip to content

feat(next): override config vars via cli - #1564

Merged
eoghanriley merged 7 commits into
mainfrom
eoghanriley/cli-315
Sep 22, 2026
Merged

eoghanriley merged 7 commits into
mainfrom
eoghanriley/cli-315

Conversation

@eoghanriley

@eoghanriley eoghanriley commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Description

This PR adds the --set flag to allow users to override config variables at deploy time.

You cannot reference hcl variables declared in defaults such as --set keycloak_domain=domain where domain is a variable set in defaults.

Related Issue

Relates to CLI-315

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@eoghanriley
eoghanriley requested a review from a team as a code owner September 17, 2026 21:24
@greptile-apps

greptile-apps Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the previously reported special-float and numeric-overflow failures are fully addressed.

Summary

Adds repeatable --set key=value overrides to standard and development bundle deployment commands.

  • Parses HCL-compatible booleans, numbers, collections, and explicitly quoted strings while preserving other values as strings.
  • Applies CLI variables after configuration resolution so they take precedence over configured values.
  • Rejects HCL numbers that cannot be represented as finite float64 values.
  • Adds unit, integration, and cluster coverage for parsing, precedence, templating, and deployment behavior.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
    CLI["deploy --set key=value"] --> Parse["ParseSetVariables"]
    Parse --> Convert["HCL parsing and type conversion"]
    Convert --> Merge["Merge over resolved config variables"]
    Merge --> Deploy["Bundle deployment and templating"]
Loading

Reviews (5) · Last reviewed commit: "fix: float64 overflow"

Comment thread internal/bundle/configuration.go Resolved
Comment thread internal/bundle/configuration.go Resolved

@chance-coleman chance-coleman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, couple small comments. One doc link not in the changed file list that needs to be updated says --set doesnt exist on Next.

Comment thread internal/cli/bundle/config_resolver.go Resolved
Comment thread docs/reference/next/config-uds-hcl.mdx Resolved
@eoghanriley
eoghanriley merged commit 968a153 into main Sep 22, 2026
58 of 59 checks passed
@eoghanriley
eoghanriley deleted the eoghanriley/cli-315 branch September 22, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants