Repository navigation
feat: allow configuring injector image on init - #1614
Merged
Merged
Conversation
Signed-off-by: Austin Abro <austinabro321@gmail.com>
AustinAbro321
changed the title
slaskawi
approved these changes
Oct 19, 2026
slaskawi
left a comment
slaskawi
left a comment
Contributor
There was a problem hiding this comment.
The changes LGTM but I wanted to ask if we need these changes for the UDS CLI Next mode as well?
Contributor
Author
|
@slaskawi We will but I don't see a pattern for configuring init options for uds cli next atm |
chance-coleman
approved these changes
Oct 19, 2026
chance-coleman
left a comment
chance-coleman
left a comment
Contributor
There was a problem hiding this comment.
This looks good, this will close this linear issue which is specific to legacy cli. Next mode is not part of this issue and tracked separately in this issue which needs some additional work to enable this feature.
joelmccoy
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There seems to be a linear issue for this, but I don't have access. This is only for the legacy, wasn't sure if this needs to be implemented for cli next. Zarf is going to make this required in proxy mode, so we need a way for users to set this zarf-dev/zarf#5476
Type of change
Checklist before merging