Repository navigation
feat(bundle): prepare deploy source from read-only oras target - #1623
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryAdds
Diagram%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Read-only target and caller loader] --> B[Resolve architecture-specific bundle]
B --> C[Read and parse bundle definition]
C --> D[Write HCL, defaults, and values]
D --> E[Return prepared source]
E --> F[Deploy with caller loader]
F --> G[Caller closes source]
G --> H[Remove private workspace]
Reviews (2) · Last reviewed commit: "docs(bundle): simplify target source com..." · Reviewed by Greptile |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0af6f19977
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0af6f19977
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Description
Add
PrepareDeploySourceFromTargetso callers can prepare a bundle from anoras.ReadOnlyTargetand supply their own package layout loader. Preparation resolves the requested architecture and materializes the bundle HCL, defaults, and values without fetching package payloads. The returned source owns a temporary workspace that callers close after deployment.Reuse bundle definition parsing and fetched HCL bytes to avoid duplicate registry reads. Target sources require a loader and do not support resume.
Related Issue
Fixes CLI-383
Type of change
Steps to Validate
go test ./internal/artifact ./internal/oci ./pkg/bundle -count=1go test -tags=library ./tests/library/... -count=1 -timeout 5mChecklist before merging