[DOM] Fix Fragment compareDocumentPosition for documentElement and empty portals - #37163
Merged
Merged
Conversation
jackpope
force-pushed
the
fragment-refs/cdp-document-element-empty-portal
branch
from
July 31, 2026 19:14
aadaa86 to
da5ac7b
Compare
github-actions
Bot
added
the
React Core Team
jackpope
force-pushed
the
fragment-refs/cdp-document-element-empty-portal
branch
from
July 31, 2026 20:15
da5ac7b to
4a6b6a4
Compare
jackpope
changed the title
jackpope
marked this pull request as ready for review
July 31, 2026 21:08
eps1lon
approved these changes
Jul 31, 2026
jackpope
force-pushed
the
fragment-refs/cdp-document-element-empty-portal
branch
from
August 9, 2026 19:15
3b288ec to
6fb8578
Compare
eps1lon
approved these changes
Aug 10, 2026
jackpope
force-pushed
the
fragment-refs/cdp-document-element-empty-portal
branch
from
August 11, 2026 03:49
6fb8578 to
630b360
Compare
jackpope
force-pushed
the
fragment-refs/cdp-document-element-empty-portal
branch
from
August 12, 2026 00:50
630b360 to
6bcdaef
Compare
jackpope
force-pushed
the
fragment-refs/cdp-document-element-empty-portal
branch
from
August 12, 2026 01:05
6bcdaef to
80eb3ea
Compare
poteto
approved these changes
Aug 12, 2026
poteto
left a comment
poteto
left a comment
Collaborator
There was a problem hiding this comment.
LGTM (light skim). Stacking stamps for the fragment-refs land sequence.
Base automatically changed from
fragment-refs/empty-fragment-host-siblings
to
main
August 12, 2026 01:13
Accept documentElement in the CONTAINS fiber fallback when there is no React fiber, and position empty portaled fragments against the portal container instead of the React host parent.
jackpope
force-pushed
the
fragment-refs/cdp-document-element-empty-portal
branch
from
August 12, 2026 01:13
80eb3ea to
d9f9024
Compare
github-actions Bot
pushed a commit
to suhyeonus/react
that referenced
this pull request
Aug 12, 2026
…pty portals (react#37163) Accept documentElement in the CONTAINS fiber fallback when there is no React fiber, and position empty portaled fragments against the portal container instead of the React host parent. DiffTrain build for [809280d](react@809280d)
github-actions Bot
pushed a commit
to suhyeonus/react
that referenced
this pull request
Aug 12, 2026
…pty portals (react#37163) Accept documentElement in the CONTAINS fiber fallback when there is no React fiber, and position empty portaled fragments against the portal container instead of the React host parent. DiffTrain build for [809280d](react@809280d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept documentElement in the CONTAINS fiber fallback when there is no React fiber, and position empty portaled fragments against the portal container instead of the React host parent.