[flags] Enable conditional use() warning in React's Canary builds - #37491
Merged
Conversation
|
Comparing: 33b4555...afe3496 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
Generated by sizebot against afe3496 |
eps1lon
marked this pull request as ready for review
September 2, 2026 14:37
hoxyq
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The warning was previously only enabled for experimental builds (
react@experimental). This enables the warning forreact@canaryas well.Keep in mind that conditional
use()is generally supported. This warning only triggers if the condition is based onpromise.status(orpromise.value). Letuse()handle that status. React will not suspend if thepromise.statusis already'fulfilled'.More information can be found in the
use()docs under "Donβt skip calling use based on whether a Promise is already settled.".We've tested this at Vercel on the latest version of SWR (which previously had conditional
use()calls) and found no false-positive warnings or excessive warnings.