Repository navigation
feat!: Require Node.js v24+ and replace WebdriverIO with Vitest - #168
Merged
Merged
Conversation
Tests now run on Node.js v24 and Deno v2 only, and the browser tests for @humanfs/web use Vitest browser mode with the Playwright provider instead of the WebdriverIO browser runner. WebdriverIO resolves chromedriver/geckodriver against whatever browser happens to be installed, so version drift made the web tests fail intermittently. Playwright ships pinned browser binaries, so the browser and its driver can't disagree. The 308-line wdio.conf.js is replaced by a 22-line vitest.config.js, and the install drops from ~1400 to 369 packages. node:assert isn't resolvable in a browser bundle, so the web tests now pass a small adapter over Chai's assert, the same way packages/deno adapts Deno's assertions. Other changes: - CI matrix moves to Node 24.x / Deno 2.x, denoland/setup-deno@v2, and installs Playwright browsers (--with-deps on Linux only). - packages/box imported dotenv, which was never declared in any package.json and only resolved because @wdio/cli hoisted it. Replaced with the built-in process.loadEnvFile(). - Deno 2 is stricter about permissions and @humanwhocodes/retry reads process.env.DEBUG, so the deno test script gains --allow-env=DEBUG. - ESLint config declares node/browser/deno/mocha globals per directory instead of scattering /* global */ comments through the sources, which clears all 92 pre-existing lint errors. Two dead private methods in memory-hfs-volume.js and several unused msw handler parameters are removed along the way. - Renovate: config:base is deprecated, so switch to config:recommended. devDependency updates stay disabled, except for the browser test stack, which pins its own browser binaries and goes stale if left unattended. BREAKING CHANGE: All packages now require Node.js v24.0.0 or later. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XXP2Ca3uGrqTf3o95SfSNn
Running `deno test` from the repo root generates a deno.lock there. Only packages/deno/deno.lock is meant to be tracked, so ignore the root one. The pattern is anchored with a leading slash because an unanchored `deno.lock` would also match packages/deno/deno.lock. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XXP2Ca3uGrqTf3o95SfSNn
Merged
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernizes the repo's test tooling: tests now run on Node.js 24+ / Deno 2 only, and the
@humanfs/webbrowser tests move from the WebdriverIO browser runner to Vitest browser mode with the Playwright provider.Why the browser tester changed
WebdriverIO resolves chromedriver/geckodriver against whatever browser happens to be installed on the machine, so version drift made the web tests fail intermittently. Playwright ships pinned browser binaries, so the browser and its driver can't disagree.
wdio.conf.js, 308 linesvitest.config.js, 22 linesnode:assertisn't resolvable in a browser bundle, so the web tests now pass a small adapter over Chai'sassertβ the same patternpackages/denoalready uses to adapt Deno's assertions.Node 24 / Deno 2
20.xβ24.x, Deno1.xβ2.x,denoland/setup-deno@v1βv2.--with-depson Linux only;npxdoesn't accept--workspace, so it usesnpm exec).engines.nodeβ>=24.0.0across all 8 packages,@types/nodeβ^24.0.0.Two latent bugs this surfaced
Both were pre-existing and would have broken CI regardless:
packages/boximporteddotenv, which was never declared in anypackage.jsonβ it only resolved because@wdio/clihoisted it into the rootnode_modules. Removing wdio broke the box tests. Replaced with the Node 24 built-inprocess.loadEnvFile()rather than adding the dependency back. Nothing in box actually readsprocess.env, so it's a no-op hook kept for exercising the live Box API.@humanwhocodes/retryreadsprocess.env.DEBUG, which now throwsNotCapable. Added the narrow--allow-env=DEBUGto the deno test script.Lint
Cleared all 92 pre-existing lint errors (
npm run lintnow exits 0). The ESLint config declares node/browser/deno/mocha globals per directory instead of scattering/* global */comments through the sources, which removes most of them. Also removed two dead private methods inmemory-hfs-volume.js(#getObject,#getObjectFromPathβ never called anywhere, and#privateso not public API) and several entirely-unused msw handler parameters.Renovate
config:baseis deprecated βconfig:recommended. devDependency updates stay disabled as before, with one exception: the browser test stack (playwright,vitest,@vitest/**) pins its own browser binaries, so leaving it unattended means testing against increasingly stale browsers. Validated withrenovate-config-validator.Review note
packages/box/tests/box-client.test.jshas a ~2000-line diff that is almost entirely whitespace β the file was 4-space indented and had never been through Prettier, and the repo's own pre-commit hook (yorkie β lint-staged βprettier --write) reformatted it on commit. The real change there is 5 removed unused handler parameters.Verification
npm run lintβ exits 0npm testβ exits 0; box 132, core 185, deno 123 steps, memory 158, node 198, web 184 (chromium + firefox)Note for release
This is marked
feat!with aBREAKING CHANGE:footer so release-please bumps every package (all are0.xwithbump-minor-pre-major, so they'll take a minor bump) for theengines.nodechange.π€ Generated with Claude Code
https://claude.ai/code/session_01XXP2Ca3uGrqTf3o95SfSNn