Skip to content

Support HTTPS when using a specific API instance - #276

Closed
acejam wants to merge 1 commit into
ipfs:masterfrom
filebase:master
Closed

acejam wants to merge 1 commit into
ipfs:masterfrom
filebase:master

Conversation

@acejam

@acejam acejam commented Jan 7, 2025

Copy link
Copy Markdown

The --api flag in Kubo is not currently usable with an API instance behind TLS. This change allows HTTPS to be used.

@welcome

welcome Bot commented Jan 7, 2025

Copy link
Copy Markdown

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@lidel lidel self-assigned this Jan 10, 2025
@lidel

lidel commented Jan 10, 2025

Copy link
Copy Markdown
Contributor

Thank you for opening this.

I am afraid hardcoding port is not the right approach – we should simply respect explicitly passed https:// scheme, when passed, and make Kubo pass it, when addr passed to ipfs --api has /https or /tls/http.

Let's continue in #277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants