Repository navigation
Run @validates for a field with a dotted attribute - #3087
Open
andrewstellman wants to merge 1 commit into
Open
andrewstellman wants to merge 1 commit into
andrewstellman wants to merge 1 commit into
Conversation
A field with attribute="a.b" is loaded into a nested dict by set_value, but _invoke_field_validators looked the value up with the literal attribute string, got a KeyError and skipped the validator. Read the value along the dotted path instead.
This was referenced Oct 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
@validatesmethod never runs for a field with a dottedattribute:The loaded value is stored nested under
a, but_invoke_field_validatorslooked it up with the literal key"a.b", got aKeyErrorand skipped the validator. It now reads the value along the dotted path. The test intests/test_decorators.pycoversmany=Falseandmany=True.I sent this to the Tidelift security contact first, and they asked for a public PR.
Found with the Quality Playbook, an AI code-review tool I maintain; I reproduced it and reviewed the fix myself.