Repository navigation
chore(deps): bump unexpected to 13 and remove unused plugins - #6135
Merged
mark-wiemer merged 15 commits intoJul 20, 2026
Merged
Conversation
1 task
JoshuaKGoldberg
force-pushed
the
unexpected-13-and-cleanup
branch
from
July 4, 2026 16:37
b8b19c7 to
5904b3c
Compare
JoshuaKGoldberg
commented
Jul 4, 2026
5 tasks done
This comment was marked as resolved.
This comment was marked as resolved.
JoshuaKGoldberg
marked this pull request as ready for review
July 6, 2026 16:33
Member
|
On phone on bus, @JoshuaKGoldberg can you explain the test failure? |
Member
Author
|
I thought it was just flake |
mark-wiemer
previously approved these changes
Jul 19, 2026
Member
|
"should instantiate a Runner" timed out on both of the first two runs. No other issues. I don't recognize this unit test as a known flaky test though. |
Member
|
@JoshuaKGoldberg the test is consistently failing, can you check it out? |
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6135 +/- ##
==========================================
+ Coverage 82.57% 82.64% +0.07%
==========================================
Files 62 62
Lines 4649 4668 +19
Branches 997 1034 +37
==========================================
+ Hits 3839 3858 +19
Misses 810 810 β View full report in Codecov by Harness. π New features to boost your workflow:
|
mark-wiemer
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
fixes #000(or is a trivial change)status: accepting prsOverview
Supersedes #5730. The failures were from the old
unexpected-mapandunexpected-setpackages not supportingunexpected@13:But we only barely use those packages' additions. I was able to rewrite them all with just a few lines of code:
plugin-loader.spec.cjs: using the nice newObject.fromEntries()parallel.spec.cjs: an odd side effect of the plugins that I rewrote to just use a couple more manual assertions.Note that
unexpected-eventemitterandunexpected-sinonare used: search"to emit from"and"was called, respectively.