Skip to content

fix(openapi): preserve after filters during cursor pagination - #5332

Merged
mergify[bot] merged 3 commits into
mvanhorn:mainfrom
zealous1:codex/cursor-date-filter
Nov 4, 2026
Merged

mergify[bot] merged 3 commits into
mvanhorn:mainfrom
zealous1:codex/cursor-date-filter

Conversation

@zealous1

@zealous1 zealous1 commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

When a GET accepts both after and cursor and returns next_cursor, send the continuation as cursor. Preserve the date filter on later pages.

The OpenAPI parser tests pass. A generated CLI retrieved both records from a two-page fixture with the same date bounds on both requests.

Fixes #5331.

@mergify

mergify Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 All 2 merge protections satisfied — ready to merge.

Show 2 satisfied protections

🟢 require-ready-label-and-ci

  • #changes-requested-reviews-by = 0
  • #review-threads-unresolved = 0
  • check-success = build-and-test
  • check-success = generated-test
  • check-success = go-lint
  • check-success = golden
  • check-success = pr-title
  • check-success = test
  • any of:
    • label = ready-to-merge
    • all of:
      • head = release-please--branches--main
      • title ~= ^chore\(main\): release
  • any of:
    • -files ~= ^(\.github/workflows/|\.github/scripts/|scripts/|\.github/CODEOWNERS$)
    • approved-reviews-by = mvanhorn
    • approved-reviews-by = tmchow
    • author = mvanhorn
    • author = tmchow
  • any of:
    • check-success = Greptile Review
    • label = queued
    • check-neutral = Greptile Review
    • check-skipped = Greptile Review
    • head ~= ^mergify/merge-queue/
    • all of:
      • head = release-please--branches--main
      • title ~= ^chore\(main\): release

🟢 🚦 Auto-queue

When all merge protections are satisfied and these conditions match, this pull request will be queued automatically.

  • label = ready-to-merge

@greptile-apps

greptile-apps Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; the previous environment-isolation issue is fixed.

Summary

The parser sends continuation values through cursor when an operation accepts both after and cursor and returns next_cursor or nextCursor.

  • Cursor-paginated requests keep their date filters on later pages.

Reviews (3) · Last reviewed commit: "test: isolate the generated pagination c..." · Reviewed by Greptile

Comment thread internal/openapi/parser_test.go Resolved
@tmchow tmchow added the ready-to-merge Queue when Mergify passes; scripts/.github PRs also need Approve from tmchow/mvanhorn. label Nov 4, 2026
@mergify mergify Bot added the queued PR is in the Mergify merge queue label Nov 4, 2026
@mergify
mergify Bot merged commit 38b74e0 into mvanhorn:main Nov 4, 2026
39 checks passed
@mergify

mergify Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

✅ Merged into main as 38b74e0 at 09:37 UTC

18 min in the queue, 17 min of it CI.

So far

13 merge conditions met
  • check-success = build-and-test · required by Merge Protections rule require-ready-label-and-ci
  • check-success = generated-test · required by Merge Protections rule require-ready-label-and-ci
  • check-success = go-lint · required by Merge Protections rule require-ready-label-and-ci
  • check-success = golden · required by Merge Protections rule require-ready-label-and-ci
  • check-success = test · required by Merge Protections rule require-ready-label-and-ci
  • github-review-approved · required by GitHub branch protection
  • #changes-requested-reviews-by = 0 · required by Merge Protections rule require-ready-label-and-ci
  • #review-threads-unresolved = 0 · required by Merge Protections rule require-ready-label-and-ci
  • check-success = pr-title · required by Merge Protections rule require-ready-label-and-ci
  • any of · required by Merge Protections rule require-ready-label-and-ci:
    • label = ready-to-merge
    • all of:
      • head = release-please--branches--main
      • title ~= ^chore\(main\): release
  • any of · required by Merge Protections rule require-ready-label-and-ci:
    • -files ~= ^(\.github/workflows/|\.github/scripts/|scripts/|\.github/CODEOWNERS$)
    • approved-reviews-by = mvanhorn
    • approved-reviews-by = tmchow
    • author = mvanhorn
    • author = tmchow
  • any of · required by Merge Protections rule require-ready-label-and-ci:
    • label = queued
    • check-neutral = Greptile Review
    • check-skipped = Greptile Review
    • check-success = Greptile Review
    • head ~= ^mergify/merge-queue/
    • all of:
      • head = release-please--branches--main
      • title ~= ^chore\(main\): release
  • any of · required by GitHub branch protection:
    • check-neutral = Mergify Merge Protections
    • check-skipped = Mergify Merge Protections
    • check-success = Mergify Merge Protections

Times in UTC · dashboard · how the merge queue works

@mergify mergify Bot removed the queued PR is in the Mergify merge queue label Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Queue when Mergify passes; scripts/.github PRs also need Approve from tmchow/mvanhorn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenAPI pagination picks the after filter over the declared cursor

2 participants