Repository navigation
fix(openapi): preserve after filters during cursor pagination - #5332
Merged
Merged
Conversation
Contributor
Merge Protections🟢 All 2 merge protections satisfied — ready to merge. Show 2 satisfied protections🟢 require-ready-label-and-ci
🟢 🚦 Auto-queueWhen all merge protections are satisfied and these conditions match, this pull request will be queued automatically.
|
Contributor
[Medium impact] The PR appears safe to merge; the previous environment-isolation issue is fixed. SummaryThe parser sends continuation values through
Reviews (3) · Last reviewed commit: "test: isolate the generated pagination c..." · Reviewed by Greptile |
Closed
56 of 96 tasks
Contributor
✅ Merged into
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a GET accepts both
afterandcursorand returnsnext_cursor, send the continuation ascursor. Preserve the date filter on later pages.The OpenAPI parser tests pass. A generated CLI retrieved both records from a two-page fixture with the same date bounds on both requests.
Fixes #5331.