Skip to content

Prometheus exporters omit empty resources and scopes without attributes - #3660

Merged
reyang merged 8 commits into
open-telemetry:mainfrom
dashpole:prometheus_empty_scopeinfo
Oct 2, 2023
Merged

reyang merged 8 commits into
open-telemetry:mainfrom
dashpole:prometheus_empty_scopeinfo

Conversation

@dashpole

Copy link
Copy Markdown
Contributor

Fixes #3657

Changes

  • otel_scope_info is only generated when scope attributes are non-empty.
  • target_info is only generated when resource attributes are non-empty.
  • update logic for receivers of prometheus to handle scopes with only name and version, but no attributes.
  • Default to a scope that identifies the prometheus receiver, instead of an empty scope.

cc @open-telemetry/wg-prometheus

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prometheus Compatibility: Consider omitting empty otel_scope_info metrics

7 participants