Repository navigation
Conversation
Previously, ToolResponseMessage and AssistantMessage instances with tool calls were silently saved with corrupted data and read back as empty stubs, polluting the LLM conversation context. This commit explicitly filters out those message types on save to prevent corrupted messages from being injected into the LLM context. Legacy TOOL rows already in the database are skipped on read. Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
tzolov
force-pushed
the
filter-tool-messages-in-jdbc-chat-memory-repository
branch
from
June 11, 2026 13:34
724b7aa to
cdf63c8
Compare
ericbottard
reviewed
Jun 11, 2026
| private static class MessageRowMapper implements RowMapper<Message> { | ||
|
|
||
| @Override | ||
| @SuppressWarnings("NullAway") // TOOL rows return null; caller filters them out |
Member
There was a problem hiding this comment.
should change return type to @Nullable Message instead to represent reality, or did I miss some exceptional situation that legitimizes this?
JdbcChatMemoryRepository
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, ToolResponseMessage and AssistantMessage instances with tool calls were silently saved with corrupted data and read back as empty stubs, polluting the LLM conversation context.
This commit explicitly filters out those message types on save to prevent corrupted messages from being injected into the LLM context. Legacy TOOL rows already in the database are skipped on read.