Repository navigation
Conversation
|
@d3jie Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@d3jie Thank you for signing the Contributor License Agreement! |
|
Thanks for the PR @d3jie! I applied some minor polish to the commit and merged to master! |
|
Thanks @jgrandja. Can you tell me about the minor polish you applied? Maybe I can learn a thing or two. :) |
|
Sure @d3jie In ReactiveAuthenticationManager result = new OAuth2LoginReactiveAuthenticationManager(getAccessTokenResponseClient(), getOauth2UserService());
...
OidcAuthorizationCodeReactiveAuthenticationManager oidc = new OidcAuthorizationCodeReactiveAuthenticationManager(getAccessTokenResponseClient(), getOidcUserService());I changed it to... ReactiveOAuth2AccessTokenResponseClient<OAuth2AuthorizationCodeGrantRequest> client = getAccessTokenResponseClient();
ReactiveAuthenticationManager result = new OAuth2LoginReactiveAuthenticationManager(client, getOauth2UserService());
...
OidcAuthorizationCodeReactiveAuthenticationManager oidc = new OidcAuthorizationCodeReactiveAuthenticationManager(client, getOidcUserService());So we re-use the And in Those were the only 2 changes. |
|
@jgrandja I can see what you did there. It didn't occur to me that I could do it this way. Many thanks. Looking forward to the next. π |
Fixes: gh-6477