Skip to content

SessionRegistryImpl uses Map.compute - #7178

Closed
jeffrey-easyesi wants to merge 1 commit into
spring-projects:masterfrom
jeffrey-easyesi:fix-sessionregistry-race
Closed

jeffrey-easyesi wants to merge 1 commit into
spring-projects:masterfrom
jeffrey-easyesi:fix-sessionregistry-race

Conversation

@jeffrey-easyesi

Copy link
Copy Markdown
Contributor

Adding/removing sessions from principals wasn't atomic. If one thread removed the last session from a principal while another thread added a new one, the addition could be lost. (gh-3189)

Adding/removing sessions from principals wasn't atomic. If one thread
removed the last session from a principal while another thread added a
new one, the addition could be lost.
@pivotal-issuemaster

Copy link
Copy Markdown

@jeffrey-easyesi Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 2, 2019
@jeffrey-easyesi

Copy link
Copy Markdown
Contributor Author

This is a much smaller change than it looks due to indentation changes. https://github.com/spring-projects/spring-security/pull/7178/files?w=1

@pivotal-issuemaster

Copy link
Copy Markdown

@jeffrey-easyesi Thank you for signing the Contributor License Agreement!

@rwinch rwinch removed the status: waiting-for-triage An issue we've not yet triaged label Aug 6, 2019
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 6, 2019
@rwinch rwinch changed the title Fix race condition in SessionRegistryImpl (#3189) SessionRegistryImpl uses Map.compute Aug 6, 2019
@rwinch rwinch added in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 6, 2019
@rwinch rwinch self-assigned this Aug 6, 2019
@rwinch rwinch added this to the 5.2.0.RC1 milestone Aug 6, 2019
@rwinch

rwinch commented Aug 6, 2019

Copy link
Copy Markdown
Member

Thanks for the PR @jeffrey-easyesi This is now merged into master via a17d664

@rwinch rwinch closed this Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants