Repository navigation
SessionRegistryImpl uses Map.compute - #7178
Closed
jeffrey-easyesi wants to merge 1 commit into
Closed
jeffrey-easyesi wants to merge 1 commit into
jeffrey-easyesi wants to merge 1 commit into
Conversation
Adding/removing sessions from principals wasn't atomic. If one thread removed the last session from a principal while another thread added a new one, the addition could be lost.
|
@jeffrey-easyesi Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
Contributor
Author
|
This is a much smaller change than it looks due to indentation changes. https://github.com/spring-projects/spring-security/pull/7178/files?w=1 |
|
@jeffrey-easyesi Thank you for signing the Contributor License Agreement! |
Member
|
Thanks for the PR @jeffrey-easyesi This is now merged into master via a17d664 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding/removing sessions from principals wasn't atomic. If one thread removed the last session from a principal while another thread added a new one, the addition could be lost. (gh-3189)