🔥 Jadwal & Hasil: strided/stride/pull/

Jklawreszuk · 2024-05-21T16:56:21Z

PR Details

Description

Goodbye telemetry! 👋

Motivation and Context

Metrics feature in Stride.Engine can be considered as leftover from the time Xenko (now Stride Engine) was closed-source. While telemetry may be useful in commercial products, Stride Engine is being developed as free and open source software by independent volunteers.

Thus, information about current needs, bugs and errors is being frequently gathered by making requests on Github or directly through discussions with others on our Discord channel and there is no need to do any much more.

PR updates also Stride.Editor.CrashReporter. Previously, user could send anonymized report to support.stride3d.net, but this service has been forgotten and is useless since we are commonly use Github. Now it is possible to view and save the created report containing metrics that can be analyzed and - if the submitter wants it - attached to a new Github issue.

Types of changes

Docs change / refactoring / dependency upgrade
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

My change requires a change to the documentation.
I have added tests to cover my changes.
All new and existing tests passed.
I have built and run the editor to try this change out.

IXLLEGACYIXL · 2024-05-21T17:02:08Z

how does the crash report look where i was able to send an email to the non existent server with the crash report?

Jklawreszuk · 2024-05-21T17:09:15Z

@IXLLEGACYIXL Welp.. It's hard to tell if this server collects data at all. @xen2 have mentioned on discord a long time ago that it's closed-source (https://discord.com/channels/500285081265635328/500292370923913222/786936723283116062). About email : "Send" button just sends collection of key-value types and it doesn't matter whether you give your email or not

Jklawreszuk · 2024-05-21T17:10:25Z

Take a look at CrashReportData object

Jklawreszuk · 2024-05-22T16:50:37Z

My work is ready for review 😊

Eideren · 2024-05-25T09:47:48Z

I think we'll need @Kryptos-FR input on this given the changes to UI stuff. Also his input on using Modern.Forms when we have Avalonia coming in.

Eideren · 2024-05-26T09:14:27Z

Fixes #1663 I think ?
Related to #3 & #204 & #1815

Kryptos-FR · 2024-05-30T15:23:38Z

using Modern.Forms when we have Avalonia coming in

If we can avoid adding new WPF/WinForms dependencies, that would be nice. What does this package bring that cannot already be done with standard controls?

Kryptos-FR · 2024-05-30T15:26:40Z

In addition, did we check with a legal adviser whether removing the privacy policy is OK? We might stop collecting metrics directly, but we should keep the crash report that user can copy/paste into an issue and/or a discord chat. That report might contain user data for which we still need to comply with some laws.

IXLLEGACYIXL · 2024-05-30T18:39:23Z

In addition, did we check with a legal adviser whether removing the privacy policy is OK? We might stop collecting metrics directly, but we should keep the crash report that user can copy/paste into an issue and/or a discord chat. That report might contain user data for which we still need to comply with some laws.

the crash report still exists but instead of mail and send report you have the open git issue button

Kryptos-FR · 2024-05-30T19:11:10Z

Removing the metrics and removing the privacy policy should be two separate PRs in my opinion. I'm not convinced the privacy policy should go.

Eideren · 2024-05-30T21:01:22Z

I doubt there is any need for a privacy policy if users provide those information of their own volition, it would fall into github's own eula. On our end we just have to make it clear that users have to review what they send over and never automate the system.

MeharDT · 2024-05-30T22:53:20Z

IIRC the App Store and Google Play mandate a privacy policy for all apps, even those that don't collect any data. Using that as a reference it would still be good practise to continue including one, even if it effectively says "we don't collect anything". I don't know what jurisdiction Stride would fall under but it provides a benchmark for users and contributors to evaluate and develop against.

Jklawreszuk · 2024-06-15T08:30:27Z

I'm not a layer ofc but, it seems to me that the solution to our problem would be to make an announcement on stride website in the form of a blog and change the content of the "Privacy policy" page. Our current Privacy policy says:

If we make material changes to this Privacy Policy, we will notify you through the Software OR the web page that provided the Software to You(the “Site”) along with information on accessing the updated Privacy Policy.

Later:

Your continued use of the Software and the Services will signify your acceptance of the changes of our Privacy Policy.

Jklawreszuk · 2024-06-15T09:06:40Z

If we can avoid adding new WPF/WinForms dependencies, that would be nice. What does this package bring that cannot already be done with standard controls?

@Kryptos-FR I used the Modern.Forms package because it is a crossplatform reimplementation of WinForms and it was extremely easy to port the code, so I did it rather as a bonus. I don't mind rollbacking the changes though if you are going to rewrite this to avalonia 👍

Kryptos-FR · 2024-06-16T17:53:36Z

@Jklawreszuk Modern.Forms is another dependency that we don't need since the cross-platform version will use Avalonia. On top of that their repo seems inactive for more than a year, and their own README indicates that it is not ready for production. We don't know what kind of bug it could bring so I don't see the benefit to replace the existing and working Winforms version.

Jklawreszuk · 2024-07-20T11:35:10Z

@Kryptos-FR Alright, I bringed back Winforms report then 👌and I also added the links to the privacy policy again

Kryptos-FR

A few remarks and an incorrect project reference in the launcher. Otherwise LGTM.

Kryptos-FR · 2024-09-11T07:19:47Z

@Jklawreszuk I tried to push to your branch but since I'm not a maintainer on this repo I couldn't.

There is a small fix to do for the Thread that is created for the crash report.

  // Stride.Launcher/CrashReport/CrashReportHelper.cs
  var crashLogThread = new Thread(CrashReport) { CurrentUICulture = englishCulture, CurrentCulture = englishCulture };
+ crashLogThread.SetApartmentState(ApartmentState.STA);

Apparently, the [STAThread] attribute on the CrashReport() method is ignored. It might only work on Main().

Jklawreszuk · 2024-09-11T13:59:34Z

Thanks for the help! I added you to my fork in that case 😅 . Might be useful in future PR's.
Are you able to push your changes now?

sources/templates/README.md (end-user CLI usage, local dev workflow, add-a-sample recipe, architecture pointers). Short pointer added to root README + docs/build/README.md Further-Reading.

dotnet new template integration

…ionTests 24 .sdtex assets across Engine/Particles/Physics/UI/Input tests now set IsCompressed: false to stop per-platform BCn-vs-ASTC divergence in gold images. New TextureCompressionTests in Stride.Graphics.Tests.10_0 exercises BC1-BC5 on desktop / ASTC_6x6 on mobile via per-platform golds. TextureHelper TODOs flag BC6H, BC7, and varied-ASTC-block-size gaps.

…ersion

When StrideDevPackages=true (set in repo-root Directory.Build.props), NuGet auto-packing is skipped entirely. Instead, stub .nupkg files redirect to dev-built DLLs via <Reference HintPath> in .props files. - Add build/GenerateDevPackages.cs: cross-platform C# script (dotnet run) that packs fresh nupkgs, strips managed DLLs, injects redirect props, and deploys stubs to NugetDev with _._ TFM markers. Reads SharedAssemblyInfo.Worktree.cs when present so the stamp/glob match the worktree-suffixed PackageVersion. - Add Stride.DevPackages.targets: sets StrideSkipAutoPack, warns if stubs missing, cleans up stubs when mode is switched off - Fix NuGetAssemblyResolver and AssemblyContainer to resolve assemblies from dev-redirect stubs at runtime (TryResolveDevRedirect). Probes $(StrideGraphicsApi) in a platform-aware order so dev DLLs resolve on Linux/macOS too, not just Direct3D11 on Windows. Eliminates ~31s of GenerateNuspec/PackTask/_StrideTriggerPackOnInnerBuild overhead on incremental GameStudio builds.

…ookups on $(StrideRoot)

…f mode 77bda82 (skip Pack trigger when BuildingSolutionFile=true) breaks the test-asset-compilation path: in slnf mode the test csproj's _StrideTriggerPackOnInnerBuild no longer dispatches Pack on its engine ProjectReferences before StrideCompileAsset, so the engine .nupkgs only land in NugetDev as the natural AfterTargets=Build chain — racing with CompilerApp.exe. Strip BuildingSolutionFile when _StrideEnsureCompilerAppPacked dispatches CompilerApp.Pack so CompilerApp's own _StrideTriggerPackOnInnerBuild fires and fans Pack out to its engine refs (Stride.UI / Stride.Physics / etc.) synchronously, before StrideCompileAsset runs.

…licate MSBuild's DispatchToInnerBuilds target re-dispatches a cross-targeting project to itself with TargetFramework set per inner. Sequential by construction — only one inner runs at a time — so the shared OutputPath (when AppendTargetFrameworkToOutputPath=false, e.g. Stride test SDK) isn't actually a race. Skip when parent==self, TargetFramework is set, and target is Build.

…nding/via-alt states

…sful test)

xen2 · 2026-07-17T01:29:34Z

👋 Apologies for the noise here.

This PR was closed unintentionally by a bad force-push to master on my side, which auto-closed a batch of PRs. GitHub won't let me (or you) reopen it, since the close is pinned to the now-rewritten commit.

I've contacted GitHub Support to try reopening these in bulk, but no guarantees. If this change is still relevant, it's a good opportunity to sync your branch with the latest master and open a fresh PR (your code is intact).

Sorry again for the disruption! 🙏

Jklawreszuk marked this pull request as draft May 22, 2024 07:20

Jklawreszuk force-pushed the metrics branch 2 times, most recently from 497109e to 1b3a56d Compare May 22, 2024 15:34

Jklawreszuk marked this pull request as ready for review May 22, 2024 15:34

Eideren requested a review from Kryptos-FR May 25, 2024 09:47

Jklawreszuk force-pushed the metrics branch from 591bf7f to d307e70 Compare June 15, 2024 08:19

Jklawreszuk mentioned this pull request Jul 13, 2024

[WIP] - [Metrics ServerApp] - New metrics serverapp #1689

Closed

2 of 9 tasks

Jklawreszuk force-pushed the metrics branch from 60d1470 to a957c49 Compare September 8, 2024 11:51

Kryptos-FR requested changes Sep 10, 2024

View reviewed changes

Jklawreszuk force-pushed the metrics branch 2 times, most recently from 4bdac67 to e220654 Compare September 10, 2024 22:38

Kryptos-FR self-requested a review September 12, 2024 07:58

xen2 and others added 19 commits May 27, 2026 15:59

docs: dotnet new templates

255487a

sources/templates/README.md (end-user CLI usage, local dev workflow, add-a-sample recipe, architecture pointers). Short pointer added to root README + docs/build/README.md Further-Reading.

Merge pull request stride3d#3192 from xen2/feature/dotnet-new

9628662

dotnet new template integration

build: skip Pack trigger when BuildingSolutionFile=true

77bda82

Worktree version: append suffix to dep versions and template PackageV…

1fbed7e

…ersion

build: preserve in-package .props/.targets in dev stubs, unify path l…

7f047be

…ookups on $(StrideRoot)

tests: opt sprite sheets out of compression for deterministic gold

88a21b3

tools/CompareGold: surface hostname/branch in /api/info, tidy cell pe…

18fa364

…nding/via-alt states

sidecar: store test image result info in json (even in case of succes…

8e71cd8

…sful test)

Remove Stride.Metrics.ServerApp

c15be2b

Remove Stride.Metrics

a627fb1

Remove PrivacyPolicy

c488d37

Remove usage of Stride.CrashReport from source

8d26444

Modernize CrashReport

00d6966

Add CrashReport to Stride.Launcher.sln

94d95e4

Fix crash report thread apartment

3cbb09d

Jklawreszuk force-pushed the metrics branch from 4041b7b to 3cbb09d Compare May 30, 2026 23:26

xen2 closed this Jul 16, 2026

xen2 force-pushed the master branch from b9fbd2e to 3d208f6 Compare July 16, 2026 22:11

github-project-automation Bot moved this from In Progress to Done in Roadmap Jul 16, 2026

Jklawreszuk mentioned this pull request Jul 19, 2026

feat : Metrics - Remove all data collection from Stride.Engine #3279

Merged

2 of 8 tasks

xen2 added this to Force-push PR recovery (2026-07-16) Jul 23, 2026

github-project-automation Bot moved this from Todo to Done in Force-push PR recovery (2026-07-16) Jul 23, 2026

github-project-automation Bot moved this to Todo in Force-push PR recovery (2026-07-16) Jul 23, 2026

xen2 moved this from Landed on master to Recreated - in review in Force-push PR recovery (2026-07-16) Jul 23, 2026

xen2 mentioned this pull request Aug 10, 2026

Crash report via Sentry #3348

Merged

5 of 8 tasks

Conversation

Jklawreszuk commented May 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Details

Description

Motivation and Context

Types of changes

Checklist

Uh oh!

IXLLEGACYIXL commented May 21, 2024

Uh oh!

Jklawreszuk commented May 21, 2024

Uh oh!

Jklawreszuk commented May 21, 2024

Uh oh!

Jklawreszuk commented May 22, 2024

Uh oh!

Eideren commented May 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Eideren commented May 26, 2024

Uh oh!

Kryptos-FR commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kryptos-FR commented May 30, 2024

Uh oh!

IXLLEGACYIXL commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kryptos-FR commented May 30, 2024

Uh oh!

Eideren commented May 30, 2024

Uh oh!

MeharDT commented May 30, 2024

Uh oh!

Jklawreszuk commented Jun 15, 2024

Uh oh!

Jklawreszuk commented Jun 15, 2024

Uh oh!

Kryptos-FR commented Jun 16, 2024

Uh oh!

Jklawreszuk commented Jul 20, 2024

Uh oh!

Kryptos-FR left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kryptos-FR commented Sep 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jklawreszuk commented Sep 11, 2024

Uh oh!

xen2 commented Jul 17, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Jklawreszuk commented May 21, 2024 •

edited

Loading

Eideren commented May 25, 2024 •

edited

Loading

Kryptos-FR commented May 30, 2024 •

edited

Loading

IXLLEGACYIXL commented May 30, 2024 •

edited

Loading

Kryptos-FR commented Sep 11, 2024 •

edited

Loading