Repository navigation
Tell the UI it was installed by Helm - #987
Draft
rossnelson wants to merge 7 commits into
Draft
rossnelson wants to merge 7 commits into
rossnelson wants to merge 7 commits into
Conversation
The UI reads TEMPORAL_UI_DISTRIBUTION to decide which artifact to point at when it offers an upgrade. Without it the chart's UI container falls back to the image default of "docker" and sends operators to Docker Hub rather than to the chart.
5 of 8 tasks
The UI now ships its upgrade notice off, so the chart turns it on for Helm installs. Reading the flag from values rather than hardcoding it keeps the daily call to the registry under the operator's control.
The UI now ships its upgrade notice off, so the chart turns it on for Helm installs. Reading the flag from values rather than hardcoding it keeps the daily call to the registry under the operator's control.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Sets
TEMPORAL_UI_DISTRIBUTION=helmon the web container.Why
The UI is growing an upgrade notice that offers a newer version of whatever artifact the user installed. It reads
TEMPORAL_UI_DISTRIBUTIONto decide which that is.The chart runs the
temporalio/uiimage, whose own default for that variable isdocker. So without this, a Helm install identifies as a raw Docker install and the notice links operators to Docker Hub instead of to this chart.Only the distribution name is needed. The notice compares the running UI version, which the UI already knows, so there is nothing version-related to inject here. That is deliberate: the chart version is a poor proxy for the UI version in both directions β chart
1.6.0pinned UI2.52.0and1.7.0pinned2.54.1, with seven UI releases published in the two months between them, and operators can overrideweb.image.tagindependently anyway.Not a values entry
This is a fact about how the chart deploys, not an operator preference, so it is hardcoded rather than exposed in
values.yaml. Operators who want to silence the notice can already setTEMPORAL_NOTIFY_ON_NEW_VERSION=falsethroughweb.additionalEnv, which is how the chart handles the neighbouring UI toggles such asTEMPORAL_DISABLE_NEWS_FETCH.Draft
The variable does nothing until a UI image ships with the upgrade notice. Holding this as a draft until that lands β happy to keep it open as the marker.
Testing
I could not render the chart locally:
helm templatefails ahead of this template on datastore validation unrelated to the change. The addition is a static entry at the same indentation as the adjacentTEMPORAL_ADDRESSentry in the sameenv:list, so CI rendering should cover it. Worth a reviewer's eye on that.