Repository navigation
Description
As of gopls v0.10.1, the go to implementation feature of the LSP supports finding all of the types which implement an interface via the "Go to Implementation" feature in VS Code and Neovim etc.
This is a feature request to add the same support for named function types, and anonymous functions.
Current behaviour
go_to_implementation_interface.mov
Go also allows you to define function types and also accept functions as a parameter. This is seen in the standard library, e.g. https://pkg.go.dev/net/http#HandlerFunc and https://pkg.go.dev/strings#IndexFunc but here's a simple example.
type FunctionType func(s string, i int)Any function that has the same signature implements that function type.
func ImplementationOfFunctionType1(s string, i int) {
}
func ImplementationOfFunctionType2(s string, i int) {
}So, you can use it like this:
func TestFunctionType(f FunctionType) {
f("s", 0)
}The current behaviour of gopls does not allow you to go to the implementation of f from within the function body of the TestFunctionType function.
go_to_implementation_function_current.mov
And this same behaviour is true of anonymous functions:
go_to_implementation_function_anon_current.mov
Expected behavior
It should be possible to go the functions which implement the signature, as per this example.
go_to_function_type_implementation.mov
I've also tested the same behaviour with my modified version of the gopls Language Server running with Neovim.
Implementation
I've got an implementation of the functionality to contribute.
Activity
findleyr commentedon Nov 4, 2022
Hi, if you already have an implementation for this, we can take a look. As long as it is not too invasive, this is a feature we'd happily accept. Thanks!
a-h commentedon Nov 4, 2022
Thanks @findleyr - I've added a PR over here: golang/tools#412
I've tried to keep the new features out of the way as much as possible.
gopherbot commentedon Oct 9, 2024
Change https://go.dev/cl/619195 mentions this issue:
gopls/internal/golang: allow Implementation on any expressiongopherbot commentedon Mar 4, 2025
Change https://go.dev/cl/654556 mentions this issue:
gopls/internal/golang: Implementations for func typesgopherbot commentedon Mar 5, 2025
Change https://go.dev/cl/655175 mentions this issue:
gopls/internal/util/fingerprint: split from cache/methodsets1 remaining item
gopls/internal/util/fingerprint: split from cache/methodsets
adonovan commentedon Jun 4, 2025
This was implemented in the local (same-package) case by CL 654556. The global case remains unaddressed.
[-]x/tools/gopls: support "go to implementation" (textDocument/implementation) for function types[/-][+]x/tools/gopls: support global "go to implementation" queries on function types [local is done][/+]