Page MenuHomePhabricator

Bug 1661935 - Integration with a new WebExtensions XDG desktop portal for native messaging on Linux r=robwu
ClosedPublic

Authored by gerard-majax on Mar 11 2022, 8:44 AM.
Referenced Files
F86083916: D140803.1795069071.diff
Wed, Nov 18, 6:17 AM
F86083869: D140803.1795068970.diff
Wed, Nov 18, 6:16 AM
F86080423: D140803.1795062148.diff
Wed, Nov 18, 4:22 AM
F86079075: D140803.1795059922.diff
Wed, Nov 18, 3:45 AM
F86078631: D140803.1795059121.diff
Wed, Nov 18, 3:32 AM
F86075230: D140803.1795053717.diff
Wed, Nov 18, 2:01 AM
F86071498: D140803.1795048039.diff
Wed, Nov 18, 12:27 AM
F86070077: D140803.1795045502.diff
Tue, Nov 17, 11:45 PM

Diff Detail

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Do you have a green try push? I'm willing to sign off and land the patch in its current state if the try push is green.

https://treeherder.mozilla.org/jobs?repo=try&revision=5b0bca716e5ffaadb3328369ac57f81d33090b63 except the mach linting, I'm not sure yet how we want to fix, but i have ideas / try in flight

on that matter of source-mach test the problem is pretty simple:

NOTE: A documentation file was modified in diff 936149

It can be previewed for one week:


If you see a problem in this automated review, please report it here.

NOTE: A documentation file was modified in diff 936249

It can be previewed for one week:


If you see a problem in this automated review, please report it here.

NOTE: A documentation file was modified in diff 936280

It can be previewed for one week:


If you see a problem in this automated review, please report it here.

Try push is green, including new tests. Extension code changes still lgtm. All other code was signed off before. Hence I am approving too.

Tests have been split to a separate patch at https://phabricator.services.mozilla.com/D227142, which will land in the same push.

As noted before at https://phabricator.services.mozilla.com/D140803?id=626421#inline-1261507 the tests are not a full end-to-end test, but a real end-to-end test can only become feasible when the portal PR gets merged and becomes available in the images we use for testing in CI.

This revision is now accepted and ready to land.Oct 29 2024, 1:55 PM
gerard-majax marked 3 inline comments as done.
This revision is now accepted and ready to land.Nov 6 2024, 7:17 PM

updating with ManagedProcess but not ready yet

gerard-majax updated this revision to Diff 945765.
This revision is now accepted and ready to land.Nov 15 2024, 11:54 AM

Code analysis found 1 defect in diff 945829:

  • 1 defect found by eslint (Mozlint)
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 945829.

Code analysis found 1 defect in diff 956419:

  • 1 defect found by eslint (Mozlint)
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 956419.

The current revision still looks good, with the nits addressed.

I'm also dropping @Gijs as a reviewer, because the code that he originally reviewed is no longer part of this patch, and the new version in the parent patch (https://phabricator.services.mozilla.com/D229496) has changed substantially.

toolkit/components/extensions/NativeMessaging.sys.mjs
397

proc can be null if portal.start() raises an error.

toolkit/modules/subprocess/Subprocess.sys.mjs
201 ↗(On Diff #956444)

This function should be moved to the parent patch (https://phabricator.services.mozilla.com/D229496).

And while you're editing anyway:

  • @param {number} fds should be used instead of @param {int[]} [fds] because int is not a JS type, and fds is not optional.
  • @returns {Promise<Process>} should be the return value instead of @returns {Process}
robwu removed a reviewer: Gijs.