Details
- Reviewers
emilio robwu rpl • andi - Group Reviewers
mach-reviewers - Commits
- rMOZILLACENTRAL0533ca878434: Bug 1661935 - Integration with a new WebExtensions XDG desktop portal for…
rMOZILLACENTRAL594beeb5e424: Bug 1661935 - Integration with a new WebExtensions XDG desktop portal for… - Bugzilla Bug ID
- 1661935
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
Event Timeline
on that matter of source-mach test the problem is pretty simple:
- python-dbusmock depends on python-dbus
- python-dbus depends on building stuff
- source mach test are ran on lint tc workers, where there's mostly nothing to allow building that package: https://searchfox.org/mozilla-central/rev/b655023a1978bcad8cc2fb038b89a058b45e91a7/taskcluster/kinds/docker-image/kind.yml#183-185 => https://searchfox.org/mozilla-central/rev/b655023a1978bcad8cc2fb038b89a058b45e91a7/taskcluster/docker/lint/system-setup.sh#9-24
It can be previewed for one week:
If you see a problem in this automated review, please report it here.
It can be previewed for one week:
If you see a problem in this automated review, please report it here.
It can be previewed for one week:
If you see a problem in this automated review, please report it here.
green try prior to splitting the patches: https://treeherder.mozilla.org/jobs?repo=try&revision=1690eada01956b0536a63193db94a1d092dcaf53
(for some reason the try with the split did not ran? https://treeherder.mozilla.org/jobs?repo=try&revision=c366cd6434ffe89d9cafdf1b0aa5055ce4431e4c)
green try of current state: https://treeherder.mozilla.org/jobs?repo=try&revision=fbeb5ead631340006061e498436c7b9d56b25b9a
Try push is green, including new tests. Extension code changes still lgtm. All other code was signed off before. Hence I am approving too.
Tests have been split to a separate patch at https://phabricator.services.mozilla.com/D227142, which will land in the same push.
As noted before at https://phabricator.services.mozilla.com/D140803?id=626421#inline-1261507 the tests are not a full end-to-end test, but a real end-to-end test can only become feasible when the portal PR gets merged and becomes available in the images we use for testing in CI.
Code analysis found 1 defect in diff 945829:
- 1 defect found by eslint (Mozlint)
You can run this analysis locally with:
- ./mach lint --warnings --outgoing
If you see a problem in this automated review, please report it here.
You can view these defects in the Diff Detail section of Phabricator diff 945829.
Code analysis found 1 defect in diff 956419:
- 1 defect found by eslint (Mozlint)
You can run this analysis locally with:
- ./mach lint --warnings --outgoing
If you see a problem in this automated review, please report it here.
You can view these defects in the Diff Detail section of Phabricator diff 956419.
The current revision still looks good, with the nits addressed.
I'm also dropping @Gijs as a reviewer, because the code that he originally reviewed is no longer part of this patch, and the new version in the parent patch (https://phabricator.services.mozilla.com/D229496) has changed substantially.
| toolkit/components/extensions/NativeMessaging.sys.mjs | ||
|---|---|---|
| 397 | proc can be null if portal.start() raises an error. | |
| toolkit/modules/subprocess/Subprocess.sys.mjs | ||
| 201 ↗ | (On Diff #956444) | This function should be moved to the parent patch (https://phabricator.services.mozilla.com/D229496). And while you're editing anyway:
|