Skip to content

Return SinkEventAttributes instead of super class MutableAttributeSet - #1036

Merged
kwin merged 1 commit into
masterfrom
feature/return-value-of-filterattributes
Feb 24, 2026
Merged

kwin merged 1 commit into
masterfrom
feature/return-value-of-filterattributes

Conversation

@kwin

@kwin kwin commented Feb 19, 2026

Copy link
Copy Markdown
Member

for filterAttributes

That way the return value can be used to easily access also the members only provided by SinkEventAttributes (e.g. the constants).

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

for filterAttributes

That way the return value can be used to easily access also the members
only provided by SinkEventAttributes (e.g. the constants).
@kwin
kwin force-pushed the feature/return-value-of-filterattributes branch from e8036b1 to e234adc Compare February 19, 2026 14:03
@kwin
kwin merged commit fc87c53 into master Feb 24, 2026
27 checks passed
@kwin
kwin deleted the feature/return-value-of-filterattributes branch February 24, 2026 15:37
@kwin kwin added the enhancement New feature or request label Feb 24, 2026
@github-actions github-actions Bot added this to the 2.1.0 milestone Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant