Repository navigation
Enforce size bounds recursively on directory content - #368
Merged
Merged
Conversation
zabetak
force-pushed
the
directory-size-rule
branch
2 times, most recently
from
June 2, 2025 15:43
32a7a25 to
98d8fb5
Compare
Enchance RequireFilesSize rule to be able to enforce size bounds in the entire content of a directory by optionally enabling the new recurscive flag. The main motivation comes from the target directory that tends to store all kind of information from jar artifacts to test logs, reports, and many other things. It is not uncommon, that small seemingly innocent changes (e.g., adding a new test) can make the target directory unreasonably large consuming many GB of disk space. When such changes sneak into the project there is a high risk of causing CI/CD instability and intermittent failures that may be hard to notice. Close apache#366
zabetak
force-pushed
the
directory-size-rule
branch
from
June 2, 2025 18:37
98d8fb5 to
5290d34
Compare
slawekjaranowski
requested changes
Jun 7, 2025
slawekjaranowski
left a comment
slawekjaranowski
left a comment
Member
There was a problem hiding this comment.
Please also update documentation in enforcer-rules/src/site/apt/requireFilesSize.apt.vm
Member
Author
|
Many thanks for the review @slawekjaranowski ! I addressed your comments and updated the documentation in 6b56ba1. I run |
slawekjaranowski
approved these changes
Jun 11, 2025
Member
|
@zabetak thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enchance RequireFilesSize rule to be able to enforce size bounds in the entire content of a directory by optionally enabling the new recurscive flag.
The main motivation comes from the target directory that tends to store all kind of information from jar artifacts to test logs, reports, and many other things. It is not uncommon, that small seemingly innocent changes (e.g., adding a new test) can make the target directory unreasonably large consuming many GB of disk space. When such changes sneak into the project there is a high risk of causing CI/CD instability and intermittent failures that may be hard to notice.
Close #366
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.