Repository navigation
Introduce ruleName for rules configuration - #893
Merged
Merged
Conversation
We can define the same rule multiple times with different configuration Each execution has the same default name, with ruleName we can differentiate them
Bukama
approved these changes
Jun 26, 2025
Bukama
left a comment
Bukama
left a comment
Contributor
There was a problem hiding this comment.
+0.5 (see comment, might be done in a separate PR, but should be considerd before first release of this features)
| public String getName() { | ||
| return name; | ||
| String ruleName = rule.getRuleName(); | ||
| return ruleName == null || ruleName.isEmpty() ? name : ruleName; |
Contributor
There was a problem hiding this comment.
Names with only whitespace are allowed as isEmpty() only checks length == 0. isBlank() (JDK 11?) implies trim() I suggest to disallow whitespace rule names.
Member
Author
There was a problem hiding this comment.
content is pom tags are trimed by default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can define the same rule multiple times with different configuration
Each execution has the same default name, with ruleName we can differentiate them