Repository navigation
Conversation
elharo
marked this pull request as ready for review
June 29, 2025 14:20
slawekjaranowski
approved these changes
Jul 6, 2025
Contributor
|
Maybe this could still be managed in top-level pom for and explicit version removed from maven-enforcer/maven-enforcer-plugin/pom.xml Lines 85 to 90 in e2c841c instead? |
Contributor
Author
|
PreDestroy is part of the JDK, no need to declare a separate dependency |
This comment was marked as off-topic.
This comment was marked as off-topic.
Contributor
Why not remove This transits from so why not manage it in top-level-parent like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.