Skip to content

Remove unused javax.annotations dependency - #899

Merged
elharo merged 1 commit into
masterfrom
javax
Jul 6, 2025
Merged

elharo merged 1 commit into
masterfrom
javax

Conversation

@elharo

@elharo elharo commented Jun 29, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@elharo
elharo marked this pull request as ready for review June 29, 2025 14:20
@elharo
elharo requested a review from slawekjaranowski June 29, 2025 14:21
@pzygielo

pzygielo commented Jul 6, 2025 •

Copy link
Copy Markdown
Contributor

Maybe this could still be managed in top-level pom for

and explicit version removed from

<dependency>
<groupId>javax.annotation</groupId>
<artifactId>javax.annotation-api</artifactId>
<version>1.3.2</version>
<scope>provided</scope>
</dependency>

instead?

@elharo

elharo commented Jul 6, 2025

Copy link
Copy Markdown
Contributor Author

PreDestroy is part of the JDK, no need to declare a separate dependency

@elharo
elharo merged commit 8da0311 into master Jul 6, 2025
@elharo
elharo deleted the javax branch July 6, 2025 11:38
@github-actions github-actions Bot added this to the 3.6.1 milestone Jul 6, 2025
@pzygielo

This comment was marked as off-topic.

@pzygielo

pzygielo commented Jul 6, 2025 •

Copy link
Copy Markdown
Contributor

no need to declare a separate dependency

Why not remove javax.annotation-api from maven-enforcer-plugin/pom.xml then?

This transits from

[INFO] +- org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.9.0.M2:provided
[INFO] |  +- javax.annotation:javax.annotation-api:jar:1.2:provided

so why not manage it in top-level-parent like javax.inject and other dependencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants