Repository navigation
[MSHARED-1151] Upgrade parent to version 39 - #58
Merged
Merged
Conversation
slawekjaranowski
requested changes
Dec 9, 2022
psiroky
commented
Dec 9, 2022
Member
|
@psiroky - I have just release parent 39, so workarounds will not needed I will need two final commits in PR - one with upgrade of parent and one with code reformat only |
* versions of both maven-pmd-plugin and taglist-maven-plugin are now coming from the parent
psiroky
force-pushed
the
MSHARED-1151
branch
from
December 15, 2022 11:20
242b47b to
9a28b44
Compare
psiroky
force-pushed
the
MSHARED-1151
branch
from
December 15, 2022 11:21
9a28b44 to
b356007
Compare
Contributor
Author
|
@slawekjaranowski I believe the PR should be ready. There are 2 commits and the build is passing locally. I have also checked the checkstyle report using |
psiroky
changed the title
slawekjaranowski
approved these changes
Dec 15, 2022
Member
|
@psiroky thanks |
slawekjaranowski
added
the
dependencies
|
Resolve #149 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes are big because of the required reformating (since the new parent brings in new code style via spotless). I did simply run
mvn spotless:apply, no manual changes have been made.Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MSHARED-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MSHARED-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.