Skip to content

Add comments to turn off SSL into the example code to avoid some compatibility issues - #552

Merged
aaron-ai merged 1 commit into
apache:masterfrom
aaron-ai:add_ssl_comments
Jun 26, 2023
Merged

aaron-ai merged 1 commit into
apache:masterfrom
aaron-ai:add_ssl_comments

Conversation

@aaron-ai

Copy link
Copy Markdown
Member

Which Issue(s) This PR Fixes

Fixes #551

Brief Description

Add comments to turn off SSL into the example code to avoid some compatibility issues.

How Did You Test This Change?

Just add comments, no need more testings.

xdkxlk
xdkxlk previously approved these changes Jun 26, 2023

@xdkxlk xdkxlk left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter

codecov-commenter commented Jun 26, 2023 •

Copy link
Copy Markdown

Codecov Report

Merging #552 (0c4501f) into master (f1d5e95) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #552   +/-   ##
=========================================
  Coverage     45.98%   45.98%           
  Complexity      667      667           
=========================================
  Files           207      207           
  Lines         11503    11503           
  Branches       2933     2933           
=========================================
  Hits           5290     5290           
  Misses         5983     5983           
  Partials        230      230           
Flag Coverage Δ
java 62.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xdkxlk xdkxlk left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaron-ai
aaron-ai merged commit 5386144 into apache:master Jun 26, 2023
terrancesli added a commit to terrancesli/rocketmq-clients that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Add comments to turn off SSL into the example code to avoid some compatibility issues.

3 participants