You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Avoid allocating when parsing single string literals - #26200
Parse a single string directly and allocate a collection only for implicit string concatenation.
Paired profiles save 1β2.4 MB on smaller projects, with estimated savings of 15β46 MB on Sphinx and Prefect and neutral timing.
Test Plan
Testing: Passed the parser test suite, workspace Clippy, hooks, and multi-project output and timing checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parserRelated to the parserperformancePotential performance improvement
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parse a single string directly and allocate a collection only for implicit string concatenation.
Paired profiles save 1β2.4 MB on smaller projects, with estimated savings of 15β46 MB on Sphinx and Prefect and neutral timing.
Test Plan
Testing: Passed the parser test suite, workspace Clippy, hooks, and multi-project output and timing checks.