Repository navigation
fix: respect transition: null in framework bindings - #2131
Merged
Merged
Conversation
The React, Vue, Solid and Svelte bindings each merged
`defaultSortableTransition` before constructing or updating the core
`Sortable`, so an explicit `transition: null` was replaced by the default
transition object and items kept animating. `null` is the documented and
typed sentinel for disabling sortable transitions, and the core already
supports it: the constructor default only applies to `undefined`, and
`Sortable.animate()` returns early on a falsy transition.
Add a `resolveSortableTransition` helper to `@dnd-kit/dom/sortable` and
use it in all four bindings, so that:
- an omitted transition resolves to `defaultSortableTransition`
- a partial transition merges with the defaults
- an explicit `null` is preserved
The `Disable transition` story previously faked this with
`{duration: 0}`; it now uses `transition: null`. The story id is
unchanged.
Fixes clauderic#2077
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 037663b The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
NektarTheo
changed the title
transition: null in framework bindingstransition: null in framework bindings
@dnd-kit/abstract
@dnd-kit/collision
@dnd-kit/dom
@dnd-kit/geometry
@dnd-kit/helpers
@dnd-kit/react
@dnd-kit/solid
@dnd-kit/state
@dnd-kit/svelte
@dnd-kit/vue
commit: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The React, Vue, Solid and Svelte bindings each merged
defaultSortableTransitionbefore constructing or updating the coreSortable, so an explicittransition: nullwas replaced by the default transition object and items kept animating.nullis the documented and typed sentinel for disabling sortable transitions, and the core already supports it: the constructor default only applies toundefined, andSortable.animate()returns early on a falsy transition.Added a
resolveSortableTransitionhelper to@dnd-kit/dom/sortableand used it in all four bindings, so that:defaultSortableTransitionnullis preservedThe
Disable transitionstory previously faked this with{duration: 0}; it now usestransition: null. The story id is unchanged.Fixes #2077