Skip to content

Checkstyle license check - depend on file from released branch - #167

Merged
slachiewicz merged 1 commit into
masterfrom
checkstyle-license
May 3, 2023
Merged

slachiewicz merged 1 commit into
masterfrom
checkstyle-license

Conversation

@slachiewicz

Copy link
Copy Markdown
Member

File in master can change or can be deleted

Closes #166

File in master can change or can be deleted

Closes #166
Comment thread pom.xml Resolved
@slachiewicz slachiewicz added the bug Something isn't working label May 3, 2023
@slachiewicz
slachiewicz merged commit d66da28 into master May 3, 2023
@slachiewicz
slachiewicz deleted the checkstyle-license branch May 3, 2023 22:27
@olamy

olamy commented May 4, 2023

Copy link
Copy Markdown
Member

If I understand correctly every project upgrading to this parent will fail if any single source file doesn't have this header?
Then how to fix the build?

@hboutemy

hboutemy commented May 5, 2023 •

Copy link
Copy Markdown
Member

oh, you're right <headerLocation>https://raw.github.com/codehaus-plexus/plexus-pom/master/src/main/resources/config/plexus-header.txt</headerLocation> is not really a safe value

notice that IIUC, we're switching to spotless for checks about this, isn't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Checkstyle license check depends on file in Github master branch

4 participants