Skip to content

Fix sisu-maven-plugin - #203

Merged
cstamas merged 5 commits into
mainfrom
issue-201
May 9, 2025
Merged

cstamas merged 5 commits into
mainfrom
issue-201

Conversation

@cstamas

@cstamas cstamas commented May 9, 2025 •

Copy link
Copy Markdown
Member

The plugin is broken, as it lacks ASM from CP. Added "simple" IT that reveals this.

Fix: "demote" ASM to plain dependency, so users even for sisu-maven-plugin can change ASM used in their builds. Also, drop the shaded "with ASM" as there is really no need for it.

Fixes #201

The plugins is broken, as it lacks ASM from CP.
@cstamas
cstamas requested a review from kwin May 9, 2025 18:36
@cstamas cstamas self-assigned this May 9, 2025
@sonarqubecloud

sonarqubecloud Bot commented May 9, 2025

Copy link
Copy Markdown

@cstamas
cstamas merged commit e2f8380 into main May 9, 2025
@cstamas
cstamas deleted the issue-201 branch May 9, 2025 20:58
@cstamas cstamas added this to the 1.0.0 milestone May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make sisu-maven-plugin use ASM-less Sisu

1 participant