Skip to content

Update source header. - #194

Merged
cstamas merged 1 commit into
mainfrom
update-license
May 8, 2025
Merged

cstamas merged 1 commit into
mainfrom
update-license

Conversation

@cstamas

@cstamas cstamas commented Apr 19, 2025 •

Copy link
Copy Markdown
Member

Based on:
https://www.eclipse.org/projects/handbook/#ip-copyright-headers

Added the "and others". I personally would go for "more generic" header (see doco above), but then we'd need to author NOTICE file that I am not happy about.

This commit needs to be agreed upon, and reformat can happen only AFTER this PR is merged, as license plugin uses GH raw URL from main branch to get the header.

Based on:
https://www.eclipse.org/projects/handbook/#ip-copyright-headers

Added the "and others". I personally would go for "more generic"
header (see doco above), but then we'd need to author NOTICE
file that I am not happy about.

This commit needs to be voted upon, and reformat can happen
only AFTER this PR is merged, as license plugin uses GH
raw URL from main branch to get the header.
@cstamas
cstamas requested review from kwin and mcculls April 19, 2025 20:57
@cstamas cstamas self-assigned this Apr 19, 2025
@cstamas
cstamas marked this pull request as ready for review April 19, 2025 20:57
@sonarqubecloud

Copy link
Copy Markdown

@cstamas

cstamas commented Apr 19, 2025

Copy link
Copy Markdown
Member Author

We have some sources that are not well formatted, also some are missing header. So someone please +1 this PR, will merge it and a followup comes with "reformat only" changes.

@cstamas

cstamas commented Apr 19, 2025

Copy link
Copy Markdown
Member Author

@kwin ping

@cstamas
cstamas merged commit f2c0f87 into main May 8, 2025
@cstamas
cstamas deleted the update-license branch May 8, 2025 19:12
cstamas added a commit that referenced this pull request May 8, 2025
License header was updated it #194 and this PR is "no code change"
just executed `mvn license:format`
cstamas added a commit that referenced this pull request May 8, 2025
License header was updated it #194 and this PR is "no code change": just executed `mvn license:format`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants