Repository navigation
fix: allow RuleTester to test files inside node_modules/ - #19499
Merged
Merged
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
1 task done
fisker
marked this pull request as ready for review
March 11, 2025 07:25
fisker
changed the title
node_modules/node_modules/ in RuleTester
fisker
changed the title
node_modules/ in RuleTesterRuleTester to test files inside node_modules/
mdjermanovic
added
accepted
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
mdjermanovic
approved these changes
Mar 11, 2025
mdjermanovic
left a comment
mdjermanovic
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks! Would like @nzakas to verify.
github-project-automation
Bot
moved this from Second Review Needed
to Complete
in Triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Stop applying default ignores to RuleTester.
Fixes #19471
Is there anything you'd like reviewers to focus on?
No